Fix some issues and add History notes

Author: nearora-msft

src/aks-preview/HISTORY.rst

@@ -12,6 +12,15 @@ To release a new version, please select a new version number (usually plus 1 to
 Pending
 +++++++
 
+18.0.b30
++++++++
+* `az aks create`: Add new parameter `--container-storage-version` to enable the given version of Azure Container Storage.
+* `az aks update`: Add new parameter `--container-storage-version` to enable the given version of Azure Container Storage.
+* `az aks create`: Change behavior of `--enable-azure-container-storage` to enable latest Azure Container Storage by default.
+* `az aks update`: Change behavior of `--enable-azure-container-storage` to enable latest Azure Container Storage by default.
+* `az aks update`: Change behavior of `--disable-azure-container-storage` to handle disable based on the installed version.
+
+
 18.0.0b29
 +++++++
 * Refactor code to suppress ssh access warning message when creating an automatic cluster.

src/aks-preview/azext_aks_preview/managed_cluster_decorator.py

@@ -4070,7 +4070,7 @@ def postprocessing_after_mc_created(self, cluster: ManagedCluster) -> None:
         enable_azure_container_storage = self.context.get_intermediate("enable_azure_container_storage")
         container_storage_version = self.context.get_intermediate("container_storage_version")
         if enable_azure_container_storage:
-            if container_storage_version is None and container_storage_version == CONST_ACSTOR_VERSION_V1:
+            if container_storage_version is not None and container_storage_version == CONST_ACSTOR_VERSION_V1:
                 if cluster.identity_profile is None or cluster.identity_profile["kubeletidentity"] is None:
                     logger.warning(
                         "Unexpected error getting kubelet's identity for the cluster. "
@@ -4152,12 +4152,6 @@ def postprocessing_after_mc_created(self, cluster: ManagedCluster) -> None:
                         scope=cluster.id,
                         resolve_assignee=False,
                     )
-        else:
-            self.context.external_functions.perform_enable_azure_container_storage(
-                self.cmd,
-                self.context.get_resource_group_name(),
-                self.context.get_name(),
-            )
 
 
 class AKSPreviewManagedClusterUpdateDecorator(AKSManagedClusterUpdateDecorator):

src/aks-preview/azext_aks_preview/tests/latest/test_validators.py

@@ -1522,7 +1522,7 @@ def test_extension_installed_storagepool_type_installed(self):
         storage_pool_size = "5Ti"
         storage_pool_type = acstor_consts.CONST_STORAGE_POOL_TYPE_AZURE_DISK
         storage_pool_sku = acstor_consts.CONST_STORAGE_POOL_SKU_PREMIUM_LRS
-        agentpools = {"nodepool1": {"node_labels": {"acstor.azure.com/io-engine": "acstor"}, "count": 3}, "nodepool2" :{}}
+        agentpools = {"nodepool1": {"node_labels": {"acstor.azure.com/io-engine": "acstor"}, "count": 3}, "nodepool2": {}}
         err = (
             "Invalid --enable-azure-container-storage value. "
             "Azure Container Storage is already enabled for storage pool type "