fix: resolve all pylint/flake8 lint errors

- Fix undefined 'inner' variable in solutionVersionId extraction
- Replace broad Exception catches with specific types
- Remove stale args from __init__.py (solution_template_rg, solution_instance_name, solution_dependencies)
- Fix line-too-long in hierarchy_create.py
- Remove unnecessary else after return
- Remove unused import time
- Fix ungrouped imports in target_prepare.py
- Add pylint disable for too-few-public-methods on CmdProxy
- Add pylint disable for unused-argument on invoke_cli_command

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: Atharva

src/workload-orchestration/azext_workload_orchestration/onboarding/__init__.py

@@ -45,9 +45,6 @@ def target_deploy(
     solution_template_version_id=None,
     solution_template_name=None,
     solution_template_version=None,
-    solution_template_rg=None,
-    solution_instance_name=None,
-    solution_dependencies=None,
     config=None,
     config_hierarchy_id=None,
     config_template_rg=None,
@@ -62,9 +59,6 @@ def target_deploy(
         solution_template_version_id=solution_template_version_id,
         solution_template_name=solution_template_name,
         solution_template_version=solution_template_version,
-        solution_template_rg=solution_template_rg,
-        solution_instance_name=solution_instance_name,
-        solution_dependencies=solution_dependencies,
         config=config,
         config_hierarchy_id=config_hierarchy_id,
         config_template_rg=config_template_rg,

src/workload-orchestration/azext_workload_orchestration/onboarding/hierarchy_create.py

@@ -88,8 +88,7 @@ def hierarchy_create(cmd, resource_group=None, configuration_location=None, hier
 
     if hierarchy_type == "ServiceGroup":
         return _create_sg_hierarchy(cmd, spec, configuration_location, resource_group)
-    else:
-        return _create_rg_hierarchy(cmd, resource_group, configuration_location, name, level)
+    return _create_rg_hierarchy(cmd, resource_group, configuration_location, name, level)
 
 
 # ---------------------------------------------------------------------------
@@ -109,9 +108,15 @@ def _log(msg, status=""):
             step[0] += 1
             print(f"[{step[0]}/{total}] {msg}...")
 
-    site_id = f"/subscriptions/{sub_id}/resourceGroups/{resource_group}/providers/{EDGE_RP_NAMESPACE}/sites/{name}"
+    site_id = (
+        f"/subscriptions/{sub_id}/resourceGroups/{resource_group}"
+        f"/providers/{EDGE_RP_NAMESPACE}/sites/{name}"
+    )
     config_name = f"{name}Config"
-    config_id = f"/subscriptions/{sub_id}/resourceGroups/{resource_group}/providers/{EDGE_RP_NAMESPACE}/configurations/{config_name}"
+    config_id = (
+        f"/subscriptions/{sub_id}/resourceGroups/{resource_group}"
+        f"/providers/{EDGE_RP_NAMESPACE}/configurations/{config_name}"
+    )
 
     print(f"\nCreating hierarchy '{name}' (level: {level}) in RG '{resource_group}'...\n")
 
@@ -189,8 +194,6 @@ def _create_sg_hierarchy(cmd, spec, config_location, resource_group):
 
 def _create_sg_level(cmd, node, config_location, sub_id, tenant_id, resource_group, parent_sg, results, depth):
     """Recursively create SG + Site + Config + ConfigRef at each level."""
-    import time
-
     name = node["name"]
     level = node["level"]
 
@@ -237,7 +240,10 @@ def _create_sg_level(cmd, node, config_location, sub_id, tenant_id, resource_gro
 
     # 3. Create Configuration (RG-scoped, NOT under SG)
     config_name = f"{name}Config"
-    config_id = f"/subscriptions/{sub_id}/resourceGroups/{resource_group}/providers/{EDGE_RP_NAMESPACE}/configurations/{config_name}"
+    config_id = (
+        f"/subscriptions/{sub_id}/resourceGroups/{resource_group}"
+        f"/providers/{EDGE_RP_NAMESPACE}/configurations/{config_name}"
+    )
     print(f"{indent}  [+] Configuration '{config_name}' (in RG: {resource_group})...")
     _arm_put(cmd, f"{ARM_ENDPOINT}{config_id}", {
         "location": config_location,

src/workload-orchestration/azext_workload_orchestration/onboarding/target_deploy.py

@@ -362,15 +362,15 @@ def _parse_response(resp, step_name, cmd=None):
     if status in (200, 201):
         try:
             return resp.json()
-        except Exception:
+        except (ValueError, AttributeError):
             return {"status": "Succeeded"}
     if status == 202:
         return _poll_lro(resp, step_name, cmd=cmd)
 
     # Error
     try:
         error_body = resp.text
-    except Exception:
+    except (ValueError, AttributeError):
         error_body = f"HTTP {status}"
     raise CLIInternalError(f"{step_name} failed (HTTP {status}): {error_body}")
 
@@ -391,13 +391,13 @@ def _poll_lro(resp, step_name, cmd=None):
         time.sleep(retry_after)
         try:
             poll_resp = send_raw_request(cmd.cli_ctx, "GET", location, resource=ARM_RESOURCE)
-        except Exception:
+        except (CLIInternalError, ValueError, ConnectionError):
             logger.debug("LRO poll attempt %d failed for %s", i + 1, step_name)
             continue
 
         try:
             body = poll_resp.json()
-        except Exception:
+        except (ValueError, AttributeError):
             continue
 
         poll_status = body.get("status", "").lower()
@@ -428,13 +428,13 @@ def _extract_solution_version_id(review_result):
         or (props.get("properties", {}) or {}).get("id")      # properties.properties.id
     )
     if not sv_id:
-        logger.warning("Could not extract solutionVersionId. Keys at top: %s, inner keys: %s, full (truncated): %s",
-                        list(review_result.keys()),
-                        list(inner.keys()) if isinstance(inner, dict) else "N/A",
-                        json.dumps(review_result, indent=2)[:800])
+        logger.warning(
+            "Could not extract solutionVersionId. Keys: %s, full (truncated): %s",
+            list(review_result.keys()),
+            json.dumps(review_result, indent=2)[:800]
+        )
         raise CLIInternalError(
-            "Review succeeded but no solutionVersionId found in response. "
-            "Use --resume-from publish --solution-version-id <id> to continue manually."
+            "Review succeeded but no solutionVersionId found in response."
         )
     return sv_id
 

src/workload-orchestration/azext_workload_orchestration/onboarding/target_prepare.py

@@ -28,6 +28,7 @@
     CLIInternalError,
     ValidationError,
 )
+from azure.cli.core.util import send_raw_request
 
 from azext_workload_orchestration.onboarding.consts import (
     DEFAULT_CERT_MANAGER_VERSION,
@@ -53,8 +54,6 @@
     print_detail,
 )
 
-from azure.cli.core.util import send_raw_request
-
 logger = logging.getLogger(__name__)
 
 TOTAL_STEPS = 4

src/workload-orchestration/azext_workload_orchestration/onboarding/utils.py

@@ -23,12 +23,8 @@
 # CmdProxy - bridge between AAZ hooks and helpers expecting cmd.cli_ctx
 # ---------------------------------------------------------------------------
 
-class CmdProxy:
-    """Lightweight proxy to pass CLI context where a full cmd object is expected.
-
-    AAZ-generated commands don't expose a cmd object in hooks, but many
-    helper functions expect cmd.cli_ctx. This proxy bridges the gap.
-    """
+class CmdProxy:  # pylint: disable=too-few-public-methods
+    """Lightweight proxy to pass CLI context where a full cmd object is expected."""
     def __init__(self, cli_ctx):
         self.cli_ctx = cli_ctx
 
@@ -87,7 +83,7 @@ def invoke_silent(cli_args):
 # CLI command invocation
 # ---------------------------------------------------------------------------
 
-def invoke_cli_command(cmd, command_args, expect_json=True):
+def invoke_cli_command(cmd, command_args, expect_json=True):  # pylint: disable=unused-argument
     """Invoke another az CLI command in-process (shares auth context).
 
     Uses get_default_cli().invoke() so the child command shares