Skip to content

Commit 7766ea8

Browse files
author
Shichao Qiu
committed
remove shell support
1 parent d8bdf33 commit 7766ea8

4 files changed

Lines changed: 3 additions & 19 deletions

File tree

src/containerapp/HISTORY.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ upcoming
1111
* 'az containerapp env premium-ingress': Deprecate `--min-replicas` and `--max-replicas` parameters, use workload profile scale instead.
1212
* 'az containerapp sessionpool create/update': Support `--probe-yaml`
1313
* 'az containerapp session stop': Support stop session for custom container sessions
14-
* 'az containerapp sessionpool create': Add `Shell` and `GpuBase` container types
14+
* 'az containerapp sessionpool create': Add `GpuBase` container type
1515

1616
1.2.0b3
1717
++++++

src/containerapp/azext_containerapp/_help.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1967,10 +1967,6 @@
19671967
text: |
19681968
az containerapp sessionpool create -n mysessionpool -g MyResourceGroup \\
19691969
--location eastasia
1970-
- name: Create or update a Session Pool with container type Shell default settings.
1971-
text: |
1972-
az containerapp sessionpool create -n mysessionpool -g MyResourceGroup \\
1973-
--container-type Shell --location westus3
19741970
- name: Create or update a Session Pool with container type GpuBase default settings.
19751971
text: |
19761972
az containerapp sessionpool create -n mysessionpool -g MyResourceGroup \\

src/containerapp/azext_containerapp/_params.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -451,7 +451,7 @@ def load_arguments(self, _):
451451
c.argument('network_status', arg_type=get_enum_type(["EgressEnabled", "EgressDisabled"]), help="Egress is enabled for the Sessions or not.")
452452

453453
with self.argument_context('containerapp sessionpool create', arg_group='Configuration') as c:
454-
c.argument('container_type', arg_type=get_enum_type(["CustomContainer", "PythonLTS", "NodeLTS", "Shell", "GpuBase"]), help="The pool type of the Session Pool, default='PythonLTS'")
454+
c.argument('container_type', arg_type=get_enum_type(["CustomContainer", "PythonLTS", "NodeLTS", "GpuBase"]), help="The pool type of the Session Pool, default='PythonLTS'")
455455
c.argument('lifecycle_type', arg_type=get_enum_type(["Timed", "OnContainerExit"]), help="The lifecycle type of the Session Pool", default='Timed')
456456

457457
with self.argument_context('containerapp sessionpool update', arg_group='Configuration') as c:

src/containerapp/azext_containerapp/tests/latest/test_containerapp_sessionpool.py

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -47,17 +47,6 @@ def test_containerapp_sessionpool_e2e(self, resource_group, subnet_id, vnet_name
4747
JMESPathCheck('properties.dynamicPoolConfiguration.lifecycleConfiguration.cooldownPeriodInSeconds', 300),
4848
])
4949

50-
# Create Shell SessionPool
51-
sessionpool_name_shell = self.create_random_name(prefix='spshell', length=24)
52-
self.cmd('containerapp sessionpool create -g {} -n {} --container-type Shell --cooldown-period {}'.format(
53-
resource_group, sessionpool_name_shell, 300), checks=[
54-
JMESPathCheck('name', sessionpool_name_shell),
55-
JMESPathCheck('properties.containerType', "Shell"),
56-
JMESPathCheck('properties.provisioningState', "Succeeded"),
57-
JMESPathCheck('properties.dynamicPoolConfiguration.lifecycleConfiguration.lifecycleType', "Timed"),
58-
JMESPathCheck('properties.dynamicPoolConfiguration.lifecycleConfiguration.cooldownPeriodInSeconds', 300),
59-
])
60-
6150
# Create GpuBase SessionPool
6251
sessionpool_name_gpu = self.create_random_name(prefix='spgpu', length=24)
6352
self.cmd('containerapp sessionpool create -g {} -n {} --container-type GpuBase --cooldown-period {}'.format(
@@ -106,7 +95,7 @@ def test_containerapp_sessionpool_e2e(self, resource_group, subnet_id, vnet_name
10695

10796
# List Session Pools
10897
sessionpool_list = self.cmd("containerapp sessionpool list -g {}".format(resource_group)).get_output_in_json()
109-
self.assertTrue(len(sessionpool_list) == 4)
98+
self.assertTrue(len(sessionpool_list) == 3)
11099

111100
# Update Session Pool
112101
max_concurrent_session = 12
@@ -154,7 +143,6 @@ def test_containerapp_sessionpool_e2e(self, resource_group, subnet_id, vnet_name
154143

155144
self.cmd('containerapp sessionpool delete -g {} -n {} --yes'.format(resource_group, sessionpool_name_python))
156145
self.cmd('containerapp sessionpool delete -g {} -n {} --yes'.format(resource_group, sessionpool_name_custom))
157-
self.cmd('containerapp sessionpool delete -g {} -n {} --yes'.format(resource_group, sessionpool_name_shell))
158146
self.cmd('containerapp sessionpool delete -g {} -n {} --yes'.format(resource_group, sessionpool_name_gpu))
159147

160148
# List Session Pools

0 commit comments

Comments
 (0)