Skip to content

Commit 8774f74

Browse files
[Containerapp] az containerapp env premium-ingress add/update: remove --min-replicas and --max-replicas (#9371)
* fix CI * update --------- Co-authored-by: xinyu pang <xinyupang@microsoft.com>
1 parent f44723d commit 8774f74

9 files changed

Lines changed: 3894 additions & 3667 deletions

.github/CODEOWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@
240240

241241
/src/quota/ @kairu-ms @ZengTaoxu
242242

243-
/src/containerapp/ @ruslany @sanchitmehta @ebencarek @JennyLawrance @howang-ms @vinisoto @chinadragon0515 @vturecek @torosent @pagariyaalok @Juliehzl @jijohn14
243+
/src/containerapp/ @ruslany @sanchitmehta @ebencarek @JennyLawrance @howang-ms @vinisoto @chinadragon0515 @vturecek @torosent @pagariyaalok @Juliehzl @jijohn14 @Greedygre @ShichaoQiu @bowen5
244244

245245
/src/scvmm/ @nascarsayan @hsurana06
246246

src/containerapp/HISTORY.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ Release History
44
===============
55
upcoming
66
++++++
7+
* 'az containerapp env premium-ingress add/update': remove `--min-replicas` and `--max-replicas`
78

89
1.2.0b4
910
++++++

src/containerapp/azext_containerapp/_params.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -531,8 +531,6 @@ def load_arguments(self, _):
531531
c.argument('resource_group_name', arg_type=resource_group_name_type, id_part=None)
532532
c.argument('name', options_list=['--name', '-n'], help="The name of the managed environment.")
533533
c.argument('workload_profile_name', options_list=['--workload-profile-name', '-w'], help="The workload profile to run ingress replicas on. This profile must not be shared with any container app or job.")
534-
c.argument('min_replicas', options_list=['--min-replicas'], type=int, deprecate_info=c.deprecate(hide=True, expiration='2.79.0'), help="The workload profile minimum instances is used instead.")
535-
c.argument('max_replicas', options_list=['--max-replicas'], type=int, deprecate_info=c.deprecate(hide=True, expiration='2.79.0'), help="The workload profile maximum instances is used instead.")
536534
c.argument('termination_grace_period', options_list=['--termination-grace-period', '-t'], type=int, help="Time in seconds to drain requests during ingress shutdown. Default 500, minimum 0, maximum 3600.")
537535
c.argument('request_idle_timeout', options_list=['--request-idle-timeout'], type=int, help="Timeout in minutes for idle requests. Default 4, minimum 4, maximum 30.")
538536
c.argument('header_count_limit', options_list=['--header-count-limit'], type=int, help="Limit of http headers per request. Default 100, minimum 1.")

src/containerapp/azext_containerapp/custom.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3873,7 +3873,7 @@ def show_environment_premium_ingress(cmd, name, resource_group_name):
38733873
handle_raw_exception(e)
38743874

38753875

3876-
def add_environment_premium_ingress(cmd, name, resource_group_name, workload_profile_name, min_replicas=None, max_replicas=None, termination_grace_period=None, request_idle_timeout=None, header_count_limit=None, no_wait=False):
3876+
def add_environment_premium_ingress(cmd, name, resource_group_name, workload_profile_name, termination_grace_period=None, request_idle_timeout=None, header_count_limit=None, no_wait=False):
38773877
_validate_subscription_registered(cmd, CONTAINER_APPS_RP)
38783878

38793879
try:
@@ -3903,7 +3903,7 @@ def add_environment_premium_ingress(cmd, name, resource_group_name, workload_pro
39033903
handle_raw_exception(e)
39043904

39053905

3906-
def update_environment_premium_ingress(cmd, name, resource_group_name, workload_profile_name=None, min_replicas=None, max_replicas=None, termination_grace_period=None, request_idle_timeout=None, header_count_limit=None, no_wait=False):
3906+
def update_environment_premium_ingress(cmd, name, resource_group_name, workload_profile_name=None, termination_grace_period=None, request_idle_timeout=None, header_count_limit=None, no_wait=False):
39073907
_validate_subscription_registered(cmd, CONTAINER_APPS_RP)
39083908

39093909
try:

src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_azurefile_e2e.yaml

Lines changed: 1453 additions & 1795 deletions
Large diffs are not rendered by default.

src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_nfsazurefile_e2e.yaml

Lines changed: 8 additions & 8 deletions
Large diffs are not rendered by default.

src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_logs_e2e.yaml

Lines changed: 6 additions & 6 deletions
Large diffs are not rendered by default.

src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_preview_connected_env_storage.yaml

Lines changed: 7 additions & 7 deletions
Large diffs are not rendered by default.

src/containerapp/azext_containerapp/tests/latest/recordings/test_containerappjob_create_with_yaml.yaml

Lines changed: 2416 additions & 1846 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)