Skip to content

Commit 9ac09b5

Browse files
authored
[Elastic-SAN] az elastic-san create: Make --base-size-tib and --extended-capacity-size-tib optional with default value of 20 and 0 (#8718)
* Make `--base-size-tib` and `--extended-capacity-size-tib` optional with default value of 20 and 0 * rerun tests
1 parent 7e760a2 commit 9ac09b5

13 files changed

Lines changed: 1983 additions & 1598 deletions

src/elastic-san/HISTORY.rst

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22
33
Release History
44
===============
5+
1.3.0
6+
++++++
7+
* `az elastic-san create`: Make `--base-size-tib` and `--extended-capacity-size-tib` optional with default value of 20 and 0
8+
59
1.2.0b3
610
++++++
711
* `az elastic-san volume restore`: Support restoring soft-deleted volume

src/elastic-san/azext_elastic_san/aaz/latest/elastic_san/_create.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,12 +124,14 @@ def _build_arguments_schema(cls, *args, **kwargs):
124124
arg_group="Properties",
125125
help="Base size of the Elastic San appliance in TiB.",
126126
required=True,
127+
default=20,
127128
)
128129
_args_schema.extended_capacity_size_tib = AAZIntArg(
129130
options=["--extended-size", "--extended-capacity-size-tib"],
130131
arg_group="Properties",
131132
help="Extended size of the Elastic San appliance in TiB.",
132133
required=True,
134+
default=0,
133135
)
134136
_args_schema.public_network_access = AAZStrArg(
135137
options=["--public-network-access"],

src/elastic-san/azext_elastic_san/commands.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,3 +16,7 @@ def load_command_table(self, _): # pylint: disable=unused-argument
1616
from .custom import VolumeGroupCreate, VolumeGroupUpdate
1717
self.command_table['elastic-san volume-group create'] = VolumeGroupCreate(loader=self)
1818
self.command_table['elastic-san volume-group update'] = VolumeGroupUpdate(loader=self)
19+
20+
with self.command_group('elastic-san'):
21+
from .custom import ElasticSanCreate
22+
self.command_table['elastic-san create'] = ElasticSanCreate(loader=self)

src/elastic-san/azext_elastic_san/custom.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
from knack.log import get_logger
1313
from .aaz.latest.elastic_san.volume_group import Create as _VolumeGroupCreate
1414
from .aaz.latest.elastic_san.volume_group import Update as _VolumeGroupUpdate
15+
from .aaz.latest.elastic_san import Create as _ElasticSanCreate
1516

1617
logger = get_logger(__name__)
1718

@@ -83,3 +84,12 @@ def pre_instance_update(self, instance):
8384
args.encryption_properties.key_vault_properties):
8485
args.encryption_properties.key_vault_properties = \
8586
instance.properties.encryption_properties.key_vault_properties
87+
88+
89+
class ElasticSanCreate(_ElasticSanCreate):
90+
@classmethod
91+
def _build_arguments_schema(cls, *args, **kwargs):
92+
args_schema = super()._build_arguments_schema(*args, **kwargs)
93+
args_schema.base_size_tib._required = False
94+
args_schema.extended_capacity_size_tib._required = False
95+
return args_schema

src/elastic-san/azext_elastic_san/tests/latest/recordings/test_elastic_san_customer_managed_key_system_assigned_identity_scenarios.yaml

Lines changed: 231 additions & 232 deletions
Large diffs are not rendered by default.

src/elastic-san/azext_elastic_san/tests/latest/recordings/test_elastic_san_customer_managed_key_user_assigned_identity_scenarios.yaml

Lines changed: 312 additions & 263 deletions
Large diffs are not rendered by default.

src/elastic-san/azext_elastic_san/tests/latest/recordings/test_elastic_san_scenarios.yaml

Lines changed: 432 additions & 81 deletions
Large diffs are not rendered by default.

src/elastic-san/azext_elastic_san/tests/latest/recordings/test_elastic_san_snapshot_scenarios.yaml

Lines changed: 332 additions & 277 deletions
Large diffs are not rendered by default.

src/elastic-san/azext_elastic_san/tests/latest/recordings/test_elastic_san_soft_delete_scenarios.yaml

Lines changed: 270 additions & 366 deletions
Large diffs are not rendered by default.

src/elastic-san/azext_elastic_san/tests/latest/recordings/test_elastic_san_test_restore_backup_scenarios.yaml

Lines changed: 160 additions & 160 deletions
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)