Skip to content

Commit ab28ca6

Browse files
committed
refactor: group blue green and rolling upgrade params separately
1 parent ccdbeb5 commit ab28ca6

1 file changed

Lines changed: 16 additions & 10 deletions

File tree

src/aks-preview/azext_aks_preview/_params.py

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1686,18 +1686,20 @@ def load_arguments(self, _):
16861686
c.argument("node_taints", validator=validate_nodepool_taints)
16871687
c.argument("node_osdisk_type", arg_type=get_enum_type(node_os_disk_types))
16881688
c.argument("node_osdisk_size", type=int)
1689+
# upgrade strategy
1690+
c.argument("upgrade_strategy", arg_type=get_enum_type(upgrade_strategies))
1691+
# rolling upgrade params
16891692
c.argument("max_surge", validator=validate_max_surge)
16901693
c.argument("drain_timeout", type=int)
16911694
c.argument("node_soak_duration", type=int)
1695+
c.argument("undrainable_node_behavior")
1696+
c.argument("max_unavailable", validator=validate_max_unavailable)
1697+
c.argument("max_blocked_nodes", validator=validate_max_blocked_nodes)
16921698
# blue-green upgrade parameters
1693-
c.argument("upgrade_strategy", arg_type=get_enum_type(upgrade_strategies))
16941699
c.argument("drain_batch_size", validator=validate_drain_batch_size)
16951700
c.argument("drain_timeout_bg", type=int)
16961701
c.argument("batch_soak_duration", type=int)
16971702
c.argument("final_soak_duration", type=int)
1698-
c.argument("undrainable_node_behavior")
1699-
c.argument("max_unavailable", validator=validate_max_unavailable)
1700-
c.argument("max_blocked_nodes", validator=validate_max_blocked_nodes)
17011703
c.argument("mode", arg_type=get_enum_type(node_mode_types))
17021704
c.argument("scale_down_mode", arg_type=get_enum_type(scale_down_modes))
17031705
c.argument("max_pods", type=int, options_list=["--max-pods", "-m"])
@@ -1830,18 +1832,20 @@ def load_arguments(self, _):
18301832
c.argument("labels", nargs="*", validator=validate_nodepool_labels)
18311833
c.argument("tags", tags_type)
18321834
c.argument("node_taints", validator=validate_nodepool_taints)
1835+
# upgrade strategy
1836+
c.argument("upgrade_strategy", arg_type=get_enum_type(upgrade_strategies))
1837+
# rolling upgrade parameters
18331838
c.argument("max_surge", validator=validate_max_surge)
18341839
c.argument("drain_timeout", type=int)
18351840
c.argument("node_soak_duration", type=int)
18361841
c.argument("undrainable_node_behavior")
1842+
c.argument("max_unavailable", validator=validate_max_unavailable)
1843+
c.argument("max_blocked_nodes", validator=validate_max_blocked_nodes)
18371844
# blue-green upgrade parameters
1838-
c.argument("upgrade_strategy", arg_type=get_enum_type(upgrade_strategies))
18391845
c.argument("drain_batch_size", validator=validate_drain_batch_size)
18401846
c.argument("drain_timeout_bg", type=int)
18411847
c.argument("batch_soak_duration", type=int)
18421848
c.argument("final_soak_duration", type=int)
1843-
c.argument("max_unavailable", validator=validate_max_unavailable)
1844-
c.argument("max_blocked_nodes", validator=validate_max_blocked_nodes)
18451849
c.argument("mode", arg_type=get_enum_type(node_mode_types))
18461850
c.argument("scale_down_mode", arg_type=get_enum_type(scale_down_modes))
18471851
# extensions
@@ -1913,18 +1917,20 @@ def load_arguments(self, _):
19131917
)
19141918

19151919
with self.argument_context("aks nodepool upgrade") as c:
1920+
# upgrade strategy
1921+
c.argument("upgrade_strategy", arg_type=get_enum_type(upgrade_strategies))
1922+
# rolling upgrade parameters
19161923
c.argument("max_surge", validator=validate_max_surge)
19171924
c.argument("drain_timeout", type=int)
19181925
c.argument("node_soak_duration", type=int)
19191926
c.argument("undrainable_node_behavior")
1927+
c.argument("max_unavailable", validator=validate_max_unavailable)
1928+
c.argument("max_blocked_nodes", validator=validate_max_blocked_nodes)
19201929
# blue-green upgrade parameters
1921-
c.argument("upgrade_strategy", arg_type=get_enum_type(upgrade_strategies))
19221930
c.argument("drain_batch_size", validator=validate_drain_batch_size)
19231931
c.argument("drain_timeout_bg", type=int)
19241932
c.argument("batch_soak_duration", type=int)
19251933
c.argument("final_soak_duration", type=int)
1926-
c.argument("max_unavailable", validator=validate_max_unavailable)
1927-
c.argument("max_blocked_nodes", validator=validate_max_blocked_nodes)
19281934
c.argument("snapshot_id", validator=validate_snapshot_id)
19291935
c.argument(
19301936
"yes",

0 commit comments

Comments
 (0)