Merge branch 'main' of https://github.com/Shekar2004/azure-cli-extensions into pgnanashekar/neon-code-removal

Author: Shekar2004

linter_exclusions.yml

@@ -124,6 +124,12 @@ aks create:
     cluster_service_load_balancer_health_probe_mode:
       rule_exclusions:
       - option_length_too_long
+    enable_service_account_image_pull:
+      rule_exclusions:
+      - option_length_too_long
+    service_account_image_pull_default_managed_identity_id:
+      rule_exclusions:
+      - option_length_too_long
 aks update:
   parameters:
     aad_admin_group_object_ids:
@@ -207,6 +213,15 @@ aks update:
     disable_application_load_balancer:
       rule_exclusions:
       - option_length_too_long
+    enable_service_account_image_pull:
+      rule_exclusions:
+      - option_length_too_long
+    disable_service_account_image_pull:
+      rule_exclusions:
+      - option_length_too_long
+    service_account_image_pull_default_managed_identity_id:
+      rule_exclusions:
+      - option_length_too_long
 aks agent:
   parameters:
     prompt:
@@ -401,6 +416,75 @@ codespace plan create:
 confidentialledger managedccfs update:
   rule_exclusions:
   - missing_command_test_coverage
+confluent organization environment:
+  rule_exclusions:
+  - require_wait_command_if_no_wait
+confluent organization environment cluster:
+  rule_exclusions:
+  - require_wait_command_if_no_wait
+confluent organization environment cluster connector:
+  rule_exclusions:
+  - require_wait_command_if_no_wait
+confluent organization environment cluster topic:
+  rule_exclusions:
+  - require_wait_command_if_no_wait
+confluent agreement default create:
+  rule_exclusions:
+  - missing_command_example
+confluent organization environment create:
+  rule_exclusions:
+  - missing_command_example
+  parameters:
+    stream_governance_config:
+      rule_exclusions:
+      - option_length_too_long
+confluent organization environment update:
+  rule_exclusions:
+  - missing_command_example
+  parameters:
+    stream_governance_config:
+      rule_exclusions:
+      - option_length_too_long
+confluent organization environment cluster create:
+  rule_exclusions:
+  - missing_command_example
+confluent organization environment cluster update:
+  rule_exclusions:
+  - missing_command_example
+confluent organization environment cluster connector create:
+  rule_exclusions:
+  - missing_command_example
+  parameters:
+    connector_service_type_info:
+      rule_exclusions:
+      - option_length_too_long
+confluent organization environment cluster connector update:
+  rule_exclusions:
+  - missing_command_example
+  parameters:
+    connector_service_type_info:
+      rule_exclusions:
+      - option_length_too_long
+confluent organization environment cluster topic create:
+  rule_exclusions:
+  - missing_command_example
+  parameters:
+    partitions_reassignments:
+      rule_exclusions:
+      - option_length_too_long
+confluent organization environment cluster topic update:
+  rule_exclusions:
+  - missing_command_example
+  parameters:
+    partitions_reassignments:
+      rule_exclusions:
+      - option_length_too_long
+confluent validation orgvalidate:
+  rule_exclusions:
+  - missing_command_example
+confluent validation orgvalidate-v2:
+  rule_exclusions:
+  - missing_command_example
 containerapp env create:
   parameters:
     infrastructure_subnet_resource_id:

src/aks-preview/HISTORY.rst

@@ -11,8 +11,15 @@ To release a new version, please select a new version number (usually plus 1 to
 
 Pending
 +++++++
+
+19.0.0b28
++++++++
 * Fix `match_condition` kwarg leaking to HTTP transport by overriding `put_mc` and `add_agentpool` to pass `if_match` / `if_none_match` directly to the vendored SDK. This change fixes the compatibility issue as azure-cli/acs module adopts TypeSpec emitted SDKs while azure-cli-extensions/aks-preview still uses the autorest emitted SDK.
 + `az aks list-vm-skus`: New command to list available VM SKUs for AKS clusters in a given region.
+* `az aks create/update`: Add `--enable-service-account-image-pull`, `--disable-service-account-image-pull`, and `--service-account-image-pull-default-managed-identity-id` parameters to manage service account based image pull settings.
+* `az aks list-vm-skus`: New command to list available VM SKUs for AKS clusters in a given region.
+* Add managed GPU enablement option to node pool property in `az aks nodepool add` and `az aks nodepool update`.
+* `az aks namespace update`: Fix location should use existing namespace location.
 
 19.0.0b27
 +++++++

src/aks-preview/azcli_aks_live_test/configs/ext_matrix_default.json

@@ -22,7 +22,9 @@
         ],
         "gpu, no quota": [
             "test_aks_nodepool_add_with_gpu_instance_profile",
-            "test_aks_gpu_driver_type"
+            "test_aks_gpu_driver_type",
+            "test_aks_nodepool_add_with_enable_managed_gpu",
+            "test_aks_nodepool_update_with_enable_managed_gpu"
         ],
         "pod ip allocation mode static block, missing feature registration": [
             "test_aks_create_with_pod_ip_allocation_mode_static_block"

src/aks-preview/azext_aks_preview/_consts.py

@@ -76,6 +76,10 @@
 CONST_GPU_DRIVER_INSTALL = "Install"
 CONST_GPU_DRIVER_NONE = "None"
 
+# gpu management mode
+CONST_GPU_MANAGEMENT_MODE_MANAGED = "Managed"
+CONST_GPU_MANAGEMENT_MODE_UNMANAGED = "Unmanaged"
+
 # consts for ManagedCluster
 # load balancer sku
 CONST_LOAD_BALANCER_SKU_BASIC = "basic"

src/aks-preview/azext_aks_preview/_help.py

@@ -519,6 +519,12 @@
         - name: --enable-image-integrity
           type: bool
           short-summary: Enable ImageIntegrity Service.
+        - name: --enable-service-account-image-pull
+          type: bool
+          short-summary: Enable service account based image pull. For more information, see https://aka.ms/aks/identity-binding/acr-image-pull/docs.
+        - name: --service-account-image-pull-default-managed-identity-id
+          type: string
+          short-summary: The default managed identity resource ID used for image pulls at the cluster level.
         - name: --dns-zone-resource-id
           type: string
           short-summary: The resource ID of the DNS zone resource to use with the App Routing addon.
@@ -1228,6 +1234,15 @@
         - name: --disable-image-integrity
           type: bool
           short-summary: Disable ImageIntegrity Service.
+        - name: --enable-service-account-image-pull
+          type: bool
+          short-summary: Enable service account based image pull. For more information, see https://aka.ms/aks/identity-binding/acr-image-pull/docs.
+        - name: --disable-service-account-image-pull
+          type: bool
+          short-summary: Disable service account based image pull.
+        - name: --service-account-image-pull-default-managed-identity-id
+          type: string
+          short-summary: The default managed identity resource ID used for image pulls at the cluster level.
         - name: --enable-apiserver-vnet-integration
           type: bool
           short-summary: Enable integration of user vnet with control plane apiserver pods.
@@ -2203,6 +2218,9 @@
         - name: --enable-artifact-streaming
           type: bool
           short-summary: Enable artifact streaming for VirtualMachineScaleSets managed by a node pool, to speed up the cold-start of containers on a node through on-demand image loading. To use this feature, container images must also enable artifact streaming on ACR. If not specified, the default is false.
+        - name: --enable-managed-gpu
+          type: bool
+          short-summary: Enable the Managed GPU experience, which installs additional components like DCGM metrics for monitoring on top of the GPU driver. For more details, visit aka.ms/aks/managed-gpu.
         - name: --skip-gpu-driver-install
           type: bool
           short-summary: To skip GPU driver auto installation by AKS on a nodepool using GPU vm size if customers want to manage GPU driver installation by their own. If not specified, the default is false.
@@ -2419,6 +2437,9 @@
         - name: --enable-artifact-streaming
           type: bool
           short-summary: Enable artifact streaming for VirtualMachineScaleSets managed by a node pool, to speed up the cold-start of containers on a node through on-demand image loading. To use this feature, container images must also enable artifact streaming on ACR. If not specified, the default is false.
+        - name: --enable-managed-gpu
+          type: bool
+          short-summary: Enable the Managed GPU experience, which installs additional components like DCGM metrics for monitoring on top of the GPU driver. For more details, visit aka.ms/aks/managed-gpu.
         - name: --os-sku
           type: string
           short-summary: The os-sku of the agent node pool.

src/aks-preview/azext_aks_preview/_params.py

@@ -899,6 +899,8 @@ def load_arguments(self, _):
         )
         c.argument("revision", validator=validate_azure_service_mesh_revision)
         c.argument("image_cleaner_interval_hours", type=int)
+        c.argument("enable_service_account_image_pull", action="store_true", is_preview=True)
+        c.argument("service_account_image_pull_default_managed_identity_id", is_preview=True)
         c.argument(
             "cluster_snapshot_id",
             validator=validate_cluster_snapshot_id,
@@ -1454,6 +1456,9 @@ def load_arguments(self, _):
         )
         c.argument("image_cleaner_interval_hours", type=int)
         c.argument("disable_image_integrity", action="store_true", is_preview=True)
+        c.argument("enable_service_account_image_pull", action="store_true", is_preview=True)
+        c.argument("disable_service_account_image_pull", action="store_true", is_preview=True)
+        c.argument("service_account_image_pull_default_managed_identity_id", is_preview=True)
         c.argument(
             "enable_apiserver_vnet_integration", action="store_true", is_preview=True
         )
@@ -2031,6 +2036,12 @@ def load_arguments(self, _):
             validator=validate_artifact_streaming,
             is_preview=True,
         )
+        c.argument(
+            "enable_managed_gpu",
+            action="store_true",
+            is_preview=True,
+            help="Enable the Managed GPU experience.",
+        )
         c.argument(
             "node_public_ip_tags",
             arg_type=tags_type,
@@ -2140,6 +2151,12 @@ def load_arguments(self, _):
             validator=validate_artifact_streaming,
             is_preview=True,
         )
+        c.argument(
+            "enable_managed_gpu",
+            action="store_true",
+            is_preview=True,
+            help="Enable the Managed GPU experience.",
+        )
         c.argument(
             "os_sku",
             arg_type=get_enum_type(node_os_skus_update),

src/aks-preview/azext_aks_preview/agentpool_decorator.py

@@ -44,7 +44,10 @@
     CONST_DEFAULT_WINDOWS_VMS_VM_SIZE,
     CONST_MANAGED_CLUSTER_SKU_NAME_AUTOMATIC,
     CONST_SSH_ACCESS_LOCALUSER,
+    CONST_GPU_DRIVER_INSTALL,
     CONST_GPU_DRIVER_NONE,
+    CONST_GPU_MANAGEMENT_MODE_MANAGED,
+    CONST_GPU_MANAGEMENT_MODE_UNMANAGED,
     CONST_NODEPOOL_MODE_MANAGEDSYSTEM,
     CONST_NODEPOOL_MODE_MACHINES,
 )
@@ -587,6 +590,27 @@ def get_enable_artifact_streaming(self) -> bool:
                 enable_artifact_streaming = self.agentpool.artifact_streaming_profile.enabled
         return enable_artifact_streaming
 
+    def get_enable_managed_gpu(self) -> Union[bool, None]:
+        """Obtain the value of enable_managed_gpu.
+        :return: bool
+        """
+
+        # read the original value passed by the command
+        enable_managed_gpu = self.raw_param.get("enable_managed_gpu")
+
+        # In create mode, try to read the property value corresponding to the parameter from the `agentpool` object
+        if self.decorator_mode == DecoratorMode.CREATE:
+            if (
+                self.agentpool and
+                self.agentpool.gpu_profile is not None and
+                self.agentpool.gpu_profile.nvidia is not None and
+                self.agentpool.gpu_profile.nvidia.management_mode is not None
+            ):
+                enable_managed_gpu = (
+                    self.agentpool.gpu_profile.nvidia.management_mode == CONST_GPU_MANAGEMENT_MODE_MANAGED
+                )
+        return enable_managed_gpu
+
     def get_pod_ip_allocation_mode(self: bool = False) -> Union[str, None]:
         """Get the value of pod_ip_allocation_mode.
         :return: str or None
@@ -1276,6 +1300,21 @@ def set_up_artifact_streaming(self, agentpool: AgentPool) -> AgentPool:
             agentpool.artifact_streaming_profile.enabled = True
         return agentpool
 
+    def set_up_managed_gpu(self, agentpool: AgentPool) -> AgentPool:
+        """Set up managed GPU property for the AgentPool object."""
+        self._ensure_agentpool(agentpool)
+
+        enable_managed_gpu = self.context.get_enable_managed_gpu()
+
+        if enable_managed_gpu:
+            if agentpool.gpu_profile is None:
+                agentpool.gpu_profile = self.models.GPUProfile()  # pylint: disable=no-member
+            if agentpool.gpu_profile.nvidia is None:
+                agentpool.gpu_profile.nvidia = self.models.NvidiaGPUProfile()  # pylint: disable=no-member
+            agentpool.gpu_profile.nvidia.management_mode = CONST_GPU_MANAGEMENT_MODE_MANAGED
+            agentpool.gpu_profile.driver = CONST_GPU_DRIVER_INSTALL
+        return agentpool
+
     def set_up_ssh_access(self, agentpool: AgentPool) -> AgentPool:
         self._ensure_agentpool(agentpool)
 
@@ -1510,6 +1549,8 @@ def construct_agentpool_profile_preview(self) -> AgentPool:
         agentpool = self.set_up_init_taints(agentpool)
         # set up artifact streaming
         agentpool = self.set_up_artifact_streaming(agentpool)
+        # set up managed gpu
+        agentpool = self.set_up_managed_gpu(agentpool)
         # set up skip_gpu_driver_install
         agentpool = self.set_up_skip_gpu_driver_install(agentpool)
         # set up gpu profile
@@ -1704,6 +1745,29 @@ def update_artifact_streaming(self, agentpool: AgentPool) -> AgentPool:
             agentpool.artifact_streaming_profile.enabled = True
         return agentpool
 
+    def update_managed_gpu(self, agentpool: AgentPool) -> AgentPool:
+        """Update managed GPU property for the AgentPool object.
+        :return: the AgentPool object
+        """
+        self._ensure_agentpool(agentpool)
+
+        enable_managed_gpu = self.context.get_enable_managed_gpu()
+        if enable_managed_gpu is None:
+            return agentpool
+
+        if enable_managed_gpu:
+            if agentpool.gpu_profile is None:
+                agentpool.gpu_profile = self.models.GPUProfile()  # pylint: disable=no-member
+            if agentpool.gpu_profile.nvidia is None:
+                agentpool.gpu_profile.nvidia = self.models.NvidiaGPUProfile()  # pylint: disable=no-member
+            agentpool.gpu_profile.nvidia.management_mode = CONST_GPU_MANAGEMENT_MODE_MANAGED
+            agentpool.gpu_profile.driver = CONST_GPU_DRIVER_INSTALL
+        else:
+            if agentpool.gpu_profile and agentpool.gpu_profile.nvidia:
+                agentpool.gpu_profile.nvidia.management_mode = CONST_GPU_MANAGEMENT_MODE_UNMANAGED
+
+        return agentpool
+
     def update_os_sku(self, agentpool: AgentPool) -> AgentPool:
         self._ensure_agentpool(agentpool)
 
@@ -1828,6 +1892,9 @@ def update_agentpool_profile_preview(self, agentpools: List[AgentPool] = None) -
         # update artifact streaming
         agentpool = self.update_artifact_streaming(agentpool)
 
+        # update managed gpu
+        agentpool = self.update_managed_gpu(agentpool)
+
         # update secure boot
         agentpool = self.update_secure_boot(agentpool)
 

src/aks-preview/azext_aks_preview/custom.py

@@ -1076,6 +1076,8 @@ def aks_create(
     enable_image_cleaner=False,
     image_cleaner_interval_hours=None,
     enable_image_integrity=False,
+    enable_service_account_image_pull=False,
+    service_account_image_pull_default_managed_identity_id=None,
     cluster_snapshot_id=None,
     enable_apiserver_vnet_integration=False,
     apiserver_subnet_id=None,
@@ -1321,6 +1323,9 @@ def aks_update(
     image_cleaner_interval_hours=None,
     enable_image_integrity=False,
     disable_image_integrity=False,
+    enable_service_account_image_pull=False,
+    disable_service_account_image_pull=False,
+    service_account_image_pull_default_managed_identity_id=None,
     enable_apiserver_vnet_integration=False,
     apiserver_subnet_id=None,
     enable_keda=False,
@@ -1919,6 +1924,7 @@ def aks_agentpool_add(
     asg_ids=None,
     node_public_ip_tags=None,
     enable_artifact_streaming=False,
+    enable_managed_gpu=False,
     skip_gpu_driver_install=False,
     gpu_driver=None,
     driver_type=None,
@@ -1993,6 +1999,7 @@ def aks_agentpool_update(
     allowed_host_ports=None,
     asg_ids=None,
     enable_artifact_streaming=False,
+    enable_managed_gpu=False,
     os_sku=None,
     ssh_access=None,
     yes=False,