Skip to content

Commit cf9fbbb

Browse files
committed
handle nan and update pending
1 parent e942096 commit cf9fbbb

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

src/aks-preview/HISTORY.rst

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@ Pending
1414
* Add MIG (Multi-Instance GPU) strategy option to node pool property in `az aks nodepool add` and `az aks nodepool update`.
1515
* `az aks create/update`: Add `--outbound-type managedNATGatewayV2` support using Azure NAT Gateway Standard V2 SKU with IPv6, user-provided IPs, and IP prefixes.
1616
* Fix monitoring addon key casing compatibility with azure-cli/acs
17+
* `az aks machine add`: Add `--spot-max-price` flag support to set the max price (in US Dollars) you are willing to pay for spot instances on a machine.
18+
* `az aks machine add`: Add `--eviction-policy` flag support to set the eviction policy for a machine.
19+
* `az aks machine add`: Add `--enable-ultra-ssd` flag support to enable ultra ssd on a machine.
1720

1821
19.0.0b28
1922
+++++++
@@ -33,9 +36,6 @@ Pending
3336
+++++++
3437
* `az aks create/update`: Add `--enable-app-routing-istio` / `--disable-app-routing-istio` (short: `--enable-ari` / `--disable-ari`) flags to enable or disable Istio as a Gateway API implementation for App Routing.
3538
* `az aks approuting gateway istio enable/disable`: Add new subcommands to enable or disable the Istio Gateway API implementation for App Routing on an existing cluster.
36-
* `az aks machine add`: Add `--spot-max-price` flag support to set the max price (in US Dollars) you are willing to pay for spot instances on a machine.
37-
* `az aks machine add`: Add `--eviction-policy` flag support to set the eviction policy for a machine.
38-
* `az aks machine add`: Add `--enable-ultra-ssd` flag support to enable ultra ssd on a machine.
3939
* Add 'mTLS' as a transit encryption type option for `--acns-transit-encryption-type` in `az aks create/update`
4040

4141
19.0.0b25

src/aks-preview/azext_aks_preview/custom.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
import time
1616
import webbrowser
1717
import subprocess
18+
from math import isnan
1819

1920
from azext_aks_preview._client_factory import (
2021
CUSTOM_MGMT_AKS_PREVIEW,
@@ -2768,6 +2769,9 @@ def aks_machine_add(
27682769
f"Machine '{machine_name}' already exists. Please use 'az aks machine update' to update it."
27692770
)
27702771

2772+
if isnan(spot_max_price):
2773+
spot_max_price = -1
2774+
27712775
# DO NOT MOVE: get all the original parameters and save them as a dictionary
27722776
raw_parameters = locals()
27732777
return add_machine(cmd, client, raw_parameters, no_wait)

0 commit comments

Comments
 (0)