Skip to content

Commit ebf066a

Browse files
Suyash ChoudharyCopilot
andcommitted
Fix schedule minute type and update tests for 2025-12-01
- Fix AAZFloatArg/AAZFloatType to AAZIntArg/AAZIntType for schedule executionTime.minute field (swagger defines as number but RP expects integer, causing ResourceCreationValidateFailed) - Restore credential type const in endpoint update command - Add short aliases for long option names (--pls-id, --data-validation, --other-source-type-desc) to pass linter - Refactor tests to use dynamic resource groups instead of hardcoded test-storagemover-rg2 - Update test endpoint names to use test- prefix (subscription policy) - Re-record test cassettes for 2025-12-01 API version - Mark tests requiring cross-subscription or physical agent resources as @record_only() Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 2d3fb9a commit ebf066a

15 files changed

Lines changed: 1464 additions & 1268 deletions

src/storage-mover/azext_storage_mover/aaz/latest/storage_mover/job_definition/_create.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -195,10 +195,10 @@ def _build_arguments_schema(cls, *args, **kwargs):
195195
minimum=0,
196196
),
197197
)
198-
execution_time.minute = AAZFloatArg(
198+
execution_time.minute = AAZIntArg(
199199
options=["minute"],
200200
help="The minute element of the time. Allowed values are 0 and 30. If not specified, its value defaults to 0.",
201-
default=0.0,
201+
default=0,
202202
enum={"0": 0, "30": 30},
203203
)
204204
return cls._args_schema
@@ -344,7 +344,7 @@ def content(self):
344344
execution_time = _builder.get(".properties.schedule.executionTime")
345345
if execution_time is not None:
346346
execution_time.set_prop("hour", AAZIntType, ".hour")
347-
execution_time.set_prop("minute", AAZFloatType, ".minute")
347+
execution_time.set_prop("minute", AAZIntType, ".minute")
348348

349349
return self.serialize_content(_content_value)
350350

@@ -484,7 +484,7 @@ def _build_schema_on_200(cls):
484484

485485
execution_time = cls._schema_on_200.properties.schedule.execution_time
486486
execution_time.hour = AAZIntType()
487-
execution_time.minute = AAZFloatType()
487+
execution_time.minute = AAZIntType()
488488

489489
source_target_map = cls._schema_on_200.properties.source_target_map
490490
source_target_map.value = AAZListType(

src/storage-mover/azext_storage_mover/aaz/latest/storage_mover/job_definition/_list.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,7 @@ def _build_schema_on_200(cls):
292292

293293
execution_time = cls._schema_on_200.value.Element.properties.schedule.execution_time
294294
execution_time.hour = AAZIntType()
295-
execution_time.minute = AAZFloatType()
295+
execution_time.minute = AAZIntType()
296296

297297
source_target_map = cls._schema_on_200.value.Element.properties.source_target_map
298298
source_target_map.value = AAZListType(

src/storage-mover/azext_storage_mover/aaz/latest/storage_mover/job_definition/_show.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ def _build_schema_on_200(cls):
291291

292292
execution_time = cls._schema_on_200.properties.schedule.execution_time
293293
execution_time.hour = AAZIntType()
294-
execution_time.minute = AAZFloatType()
294+
execution_time.minute = AAZIntType()
295295

296296
source_target_map = cls._schema_on_200.properties.source_target_map
297297
source_target_map.value = AAZListType(

src/storage-mover/azext_storage_mover/aaz/latest/storage_mover/job_definition/_update.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ def _build_arguments_schema(cls, *args, **kwargs):
196196
minimum=0,
197197
),
198198
)
199-
execution_time.minute = AAZFloatArg(
199+
execution_time.minute = AAZIntArg(
200200
options=["minute"],
201201
help="The minute element of the time. Allowed values are 0 and 30. If not specified, its value defaults to 0.",
202202
nullable=True,
@@ -478,7 +478,7 @@ def _update_instance(self, instance):
478478
execution_time = _builder.get(".properties.schedule.executionTime")
479479
if execution_time is not None:
480480
execution_time.set_prop("hour", AAZIntType, ".hour")
481-
execution_time.set_prop("minute", AAZFloatType, ".minute")
481+
execution_time.set_prop("minute", AAZIntType, ".minute")
482482

483483
return _instance_value
484484

@@ -627,7 +627,7 @@ def _build_schema_job_definition_read(cls, _schema):
627627

628628
execution_time = _schema_job_definition_read.properties.schedule.execution_time
629629
execution_time.hour = AAZIntType()
630-
execution_time.minute = AAZFloatType()
630+
execution_time.minute = AAZIntType()
631631

632632
source_target_map = _schema_job_definition_read.properties.source_target_map
633633
source_target_map.value = AAZListType(

src/storage-mover/azext_storage_mover/aaz/latest/storage_mover/job_definition/_wait.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,7 @@ def _build_schema_on_200(cls):
290290

291291
execution_time = cls._schema_on_200.properties.schedule.execution_time
292292
execution_time.hour = AAZIntType()
293-
execution_time.minute = AAZFloatType()
293+
execution_time.minute = AAZIntType()
294294

295295
source_target_map = cls._schema_on_200.properties.source_target_map
296296
source_target_map.value = AAZListType(

src/storage-mover/azext_storage_mover/tests/latest/recordings/test_storage_mover_agent_upload_limit_schedule_scenarios.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ interactions:
2828
content-type:
2929
- application/json; charset=utf-8
3030
date:
31-
- Thu, 09 Apr 2026 11:07:20 GMT
31+
- Fri, 10 Apr 2026 06:14:02 GMT
3232
expires:
3333
- '-1'
3434
pragma:
@@ -42,7 +42,7 @@ interactions:
4242
x-ms-failure-cause:
4343
- gateway
4444
x-msedge-ref:
45-
- 'Ref A: BB3D1A9B05194ACDA911C37FA8B4B3FB Ref B: PNQ231110907052 Ref C: 2026-04-09T11:07:20Z'
45+
- 'Ref A: 21C2E97D348D4E7CA97204EB5FEA1ED6 Ref B: PNQ231110908023 Ref C: 2026-04-10T06:14:01Z'
4646
status:
4747
code: 404
4848
message: Not Found

0 commit comments

Comments
 (0)