{Image-copy} Mask the value of the --sas-token parameter when displaying it in the terminal (#9516)

Author: yanzhudd

src/image-copy/HISTORY.rst

@@ -3,6 +3,10 @@
 Release History
 ===============
 
+1.0.4
+++++++
+* Mask the value of the `--sas-token` parameter when displaying it in the terminal
+
 1.0.3
 ++++++
 * Fix the issue for sasTokenParsing, removing python related warnings from the sasToken(cmd_output was unfiltered)

src/image-copy/azext_imagecopy/cli_utils.py

@@ -19,7 +19,7 @@
 def run_cli_command(cmd, return_as_json=False):
     try:
         cmd_output = check_output(cmd, stderr=STDOUT, universal_newlines=True)
-        logger.debug('command: %s ended with output: %s', cmd, cmd_output)
+        logger.debug('command: %s ended with output: %s', _mask_output_token(cmd), cmd_output)
 
         if return_as_json:
             if cmd_output:
@@ -40,15 +40,25 @@ def run_cli_command(cmd, return_as_json=False):
             raise CLIError("Command returned an unexpected empty string.")
         return cmd_output
     except CalledProcessError as ex:
-        logger.error('command failed: %s', cmd)
+        logger.error('command failed: %s', _mask_output_token(cmd))
         logger.error('output: %s', ex.output)
         raise ex
     except Exception as ex:
-        logger.error('command ended with an error: %s', cmd)
+        logger.error('command ended with an error: %s', _mask_output_token(cmd))
         logger.error('args: %s', ex.args)
         raise ex
 
 
+def _mask_output_token(cmd):
+    output = cmd[:]
+    token_param_name = "--sas-token"
+    if token_param_name in output:
+        idx = output.index(token_param_name)
+        output[idx + 1] = "******"
+
+    return output
+
+
 def prepare_cli_command(cmd, output_as_json=True, tags=None, subscription=None, only_show_errors=None):
     full_cmd = [sys.executable, '-m', 'azure.cli'] + cmd
 

src/image-copy/setup.py

@@ -8,7 +8,7 @@
 from codecs import open
 from setuptools import find_packages, setup
 
-VERSION = "1.0.3"
+VERSION = "1.0.4"
 
 CLASSIFIERS = [
     'Development Status :: 4 - Beta',