Fix issues

Author: Henry Dai

src/azure-changesafety/README.md

@@ -73,13 +73,12 @@ az changesafety changerecord create \
   --links name=Runbook uri=https://contoso.com/runbook
 ```
 
-Update the rollout type and add a comment:
+Update the ChangeRecord and add a comment:
 ```bash
 az changesafety changerecord update \
   -g MyResourceGroup \
   -n changerecord-webapp-rollout \
-  --rollout-type Emergency \
-  --comments "Escalated due to customer impact"
+  --comments "Deployment validated in canary region"
 ```
 
 ### StageProgression Examples

src/azure-changesafety/azext_changesafety/custom.py

@@ -5,6 +5,8 @@
 # Code generated by aaz-dev-tools
 # --------------------------------------------------------------------------------------------
 
+# pylint: disable=line-too-long
+
 """Custom command overrides for azure-changesafety CLI extension.
 
 This module provides customizations for ChangeRecord CRUD operations:
@@ -424,41 +426,49 @@ def _build_change_definition(self):
             }
         }
 
+    @staticmethod
+    def _parse_key_value_segment(segment):
+        """Parse a single key=value segment and return (mapped_key, value)."""
+        if '=' not in segment:
+            raise InvalidArgumentValueError('Each --targets entry must be in key=value format.')
+        key, value = segment.split('=', 1)
+        key = key.strip()
+        value = value.strip()
+        if not key or not value:
+            raise InvalidArgumentValueError('Each --targets entry must include a non-empty key and value.')
+        normalized_key = key.lower()
+        if normalized_key in TARGET_KEY_MAPPING:
+            mapped_key = TARGET_KEY_MAPPING[normalized_key]
+            if mapped_key == 'httpMethod' and value:
+                value = value.upper()
+            return mapped_key, value
+        return key, value
+
+    @staticmethod
+    def _tokenize_target(token):
+        """Split a target token into segments, handling both ; and , delimiters."""
+        if token is None:
+            return []
+        segments = []
+        for part in str(token).split(';'):
+            segments.extend(segment.strip() for segment in part.split(',') if segment.strip())
+        return segments
+
     @staticmethod
     def _parse_targets(raw_targets):
-        if raw_targets is None:
-            raise InvalidArgumentValueError('--targets is required and must include key=value pairs.')
         if not raw_targets:
             raise InvalidArgumentValueError('--targets is required and must include key=value pairs.')
         parsed_targets = []
         for token in raw_targets:
-            if token is None:
-                continue
-            segments = []
-            for part in str(token).split(';'):
-                segments.extend(segment.strip() for segment in part.split(',') if segment.strip())
+            segments = ChangeRecordCreate._tokenize_target(token)
             if not segments:
                 continue
             target_entry = {}
             for segment in segments:
-                if '=' not in segment:
-                    raise InvalidArgumentValueError('Each --targets entry must be in key=value format.')
-                key, value = segment.split('=', 1)
-                key = key.strip()
-                value = value.strip()
-                if not key or not value:
-                    raise InvalidArgumentValueError('Each --targets entry must include a non-empty key and value.')
-                normalized_key = key.lower()
-                if normalized_key in TARGET_KEY_MAPPING:
-                    mapped_key = TARGET_KEY_MAPPING[normalized_key]
-                    if mapped_key == 'httpMethod' and value:
-                        value = value.upper()
-                    target_entry[mapped_key] = value
-                else:
-                    target_entry[key] = value
-            if not target_entry:
-                continue
-            parsed_targets.append(target_entry)
+                mapped_key, value = ChangeRecordCreate._parse_key_value_segment(segment)
+                target_entry[mapped_key] = value
+            if target_entry:
+                parsed_targets.append(target_entry)
         if not parsed_targets:
             raise InvalidArgumentValueError('--targets must include at least one key=value pair.')
         return parsed_targets
@@ -470,13 +480,17 @@ def _output(self, *args, **kwargs):
 
     class ChangeRecordsCreateOrUpdateAtSubscriptionLevel(
             _ChangeRecordCreate.ChangeRecordsCreateOrUpdateAtSubscriptionLevel):
+        """Override PUT at subscription level to inject custom changeDefinition."""
+
         @property
         def content(self):
             content = super().content
             return _inject_change_definition_into_content(content, self.ctx)
 
     class ChangeRecordsCreateOrUpdate(
             _ChangeRecordCreate.ChangeRecordsCreateOrUpdate):
+        """Override PUT at resource group level to inject custom changeDefinition."""
+
         @property
         def content(self):
             content = super().content
@@ -517,6 +531,8 @@ def pre_operations(self):
 
     class ChangeRecordsGetAtSubscriptionLevel(
             _ChangeRecordUpdate.ChangeRecordsGetAtSubscriptionLevel):
+        """Override GET at subscription level to capture original changeDefinition."""
+
         def on_200(self, session):
             # Capture raw changeDefinition from HTTP response before schema loses details
             data = self.deserialize_http_content(session)
@@ -528,6 +544,8 @@ def on_200(self, session):
             return super().on_200(session)
 
     class ChangeRecordsGet(_ChangeRecordUpdate.ChangeRecordsGet):
+        """Override GET at resource group level to capture original changeDefinition."""
+
         def on_200(self, session):
             # Capture raw changeDefinition from HTTP response before schema loses details
             data = self.deserialize_http_content(session)
@@ -540,6 +558,8 @@ def on_200(self, session):
 
     class ChangeRecordsCreateOrUpdateAtSubscriptionLevel(
             _ChangeRecordUpdate.ChangeRecordsCreateOrUpdateAtSubscriptionLevel):
+        """Override PUT at subscription level to preserve original changeDefinition."""
+
         @property
         def content(self):
             content = super().content
@@ -548,6 +568,8 @@ def content(self):
 
     class ChangeRecordsCreateOrUpdate(
             _ChangeRecordUpdate.ChangeRecordsCreateOrUpdate):
+        """Override PUT at resource group level to preserve original changeDefinition."""
+
         @property
         def content(self):
             content = super().content
@@ -715,7 +737,7 @@ class ChangeRecordDelete(_ChangeRecordDelete):
 # StageMap Help Examples
 # -----------------------------------------------------------------------------
 # pylint: disable=wrong-import-position
-from azext_changesafety.aaz.latest.changesafety.stagemap import (
+from azext_changesafety.aaz.latest.changesafety.stagemap import (  # noqa: E402
     Create as _StageMapCreate,
     Show as _StageMapShow,
     Update as _StageMapUpdate,
@@ -818,7 +840,7 @@ class ChangeRecordDelete(_ChangeRecordDelete):
 # StageProgression Help Examples
 # -----------------------------------------------------------------------------
 # pylint: disable=wrong-import-position
-from azext_changesafety.aaz.latest.changesafety.stageprogression import (
+from azext_changesafety.aaz.latest.changesafety.stageprogression import (  # noqa: E402
     Create as _StageProgressionCreate,
     Show as _StageProgressionShow,
     Update as _StageProgressionUpdate,
@@ -828,7 +850,7 @@ class ChangeRecordDelete(_ChangeRecordDelete):
 
 _StageProgressionCreate.AZ_HELP = {
     **_StageProgressionCreate.AZ_HELP,
-    "short-summary": "Create a StageProgression to track the progress of a stage in a ChangeRecord.",
+    "short-summary": "Create a StageProgression to track stage progress.",
     "long-summary": (
         "A StageProgression records the execution status of a specific stage defined "
         "in a StageMap. Use this to track which stages have started, completed, or failed "

src/azure-changesafety/setup.py

@@ -47,4 +47,3 @@
     package_data={'azext_changesafety': ['azext_metadata.json']},
     install_requires=DEPENDENCIES
 )
-