{AKS} Add custom ca certs to aks create and aks update#5561
{AKS} Add custom ca certs to aks create and aks update#5561zhoxing-ms merged 30 commits intoAzure:mainfrom
Conversation
|
AKS |
FumingZhang
left a comment
There was a problem hiding this comment.
For all preview API versions since 2022-09-02-preview, a new property named ManagedClusterSecurityProfileCustomCATrustCertificates is added in containerservice(AKS). The property is declared with type array, where the value of each item is of type string and format byte. Thus, the generated SDK declares the property as type [btyearray]. It could be seen that the serialization helpers that comes with the SDK could handle properties of type bytearray. But the serialization processing in knack is not competent, which would result in the following error
I've opened a PR #268 to fix the issue. Any comments are welcome. cc @zhoxing-ms, @jiasli
There was a problem hiding this comment.
| custom_ca_certs = read_file_content(custom_ca_certs_file_path) | |
| custom_ca_certs = str.encode(read_file_content(custom_ca_certs_file_path)) |
There was a problem hiding this comment.
No need to encode the content in advance.
a97d8eb to
0109638
Compare
|
PR #5575 would resolve the serialization issue. |
6d22eba to
ff16238
Compare
There was a problem hiding this comment.
missing trailing space, two options are combined together.
| '--aks-custom-headers=AKSHTTPCustomFeatures=Microsoft.ContainerService/CustomCATrustPreview' \ | |
| '--aks-custom-headers=AKSHTTPCustomFeatures=Microsoft.ContainerService/CustomCATrustPreview ' \ |
|
You'll also need the recording file for the new test case Queued a pipeline to run it. Still running. After it succeeds, you could download the recording file from pipeline artifact and commit it. |
Test failed again 😢 |
This reverts commit 490990694d38d8eb8d33e75d7a7b5c8f4d65727f.
b4a7e90 to
1e86430
Compare
|
[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=20181&view=results |

This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify
src/index.json.