Parameterize SSH extension for the air gapped clouds#8580
Parameterize SSH extension for the air gapped clouds#8580mcnealm13 wants to merge 5 commits intoAzure:mainfrom
Conversation
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Hi @mcnealm13, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
Hi @mcnealm13 Release SuggestionsModule: ssh
Notes
|
| if (len(active_directory_graph_api_array) == 4): | ||
| scope_postfix = ( | ||
| active_directory_graph_api_array[1] | ||
| + "." | ||
| + active_directory_graph_api_array[2] | ||
| + "." | ||
| + active_directory_graph_api_array[3] | ||
| ) | ||
| # special case for USNat | ||
| elif len(active_directory_graph_api_array) == 5: | ||
| scope_postfix = ( | ||
| active_directory_graph_api_array[1] | ||
| + "." | ||
| + active_directory_graph_api_array[2] | ||
| + "." | ||
| + active_directory_graph_api_array[3] | ||
| + "." | ||
| + active_directory_graph_api_array[4] | ||
| ) | ||
| else: | ||
| raise azclierror.InvalidArgumentValueError( | ||
| f"Unsupported cloud {cmd.cli_ctx.cloud.name.lower()}", | ||
| "Supported clouds include azurecloud,azurechinacloud,azureusgovernment") | ||
| scope = f"https://pas.{scope}/CheckMyAccess/Linux/.default" |
There was a problem hiding this comment.
The scope_postfix variable doesn't seem to be used in the new scope
|
@vthiebaut10 can you review again ? CC @anwarnuma |
jiasli
left a comment
jiasli
left a comment
There was a problem hiding this comment.
String manipulation is too fragile. I don't favor the solution proposed by this PR.
|
Previously the SSH auth scope is hard-coded in Azure PowerShell, and later it leverages "Environment" to store the scope to support new sovereign clouds:
This approach makes sense to me. We can add |
8 participants
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.