[k8s-extension] Remove code related to EntraWorkloadIAM#8783
[k8s-extension] Remove code related to EntraWorkloadIAM#8783zhoxing-ms merged 1 commit intoAzure:mainfrom AntonioND:anninodi/delete
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @AntonioND, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull Request Overview
This PR removes the now-unneeded EntraWorkloadIAM extension and its associated tests and registration.
- Deleted all tests for the EntraWorkloadIAM partner extension.
- Removed the EntraWorkloadIAM implementation module.
- Cleared the EntraWorkloadIAM import and factory mapping in
custom.py.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/k8s-extension/azext_k8s_extension/tests/latest/test_entra_workload_iam.py | Removed tests for EntraWorkloadIAM |
| src/k8s-extension/azext_k8s_extension/partner_extensions/EntraWorkloadIAM.py | Deleted EntraWorkloadIAM extension implementation |
| src/k8s-extension/azext_k8s_extension/custom.py | Removed import and factory entry for EntraWorkloadIAM |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
|
Hi! Can I get a review here? The Arc extension that required this code was cancelled months ago. This is dead code and it should be removed. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
It looks like all the style issues in the pipelines are in code that hasn't been touched by this PR. |
|
[Release] Update index.json for extension [ k8s-extension-1.6.6 ] : https://dev.azure.com/msazure/One/_build/results?buildId=131982681&view=results |
This code is no longer required. Its original purpose was to generate a join token without user input to simplify the setup of the extension.
This PR is the same as AzureArcForKubernetes#287 but applied to this repository.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.