Skip to content

feat(acns): add transit encryption options for az create and update commands #8784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yanzhudd merged 1 commit into from
Jun 12, 2025
Merged

feat(acns): add transit encryption options for az create and update commands #8784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/aks-preview/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ To release a new version, please select a new version number (usually plus 1 to
Pending
+++++++

18.0.0b12
+++++++
* Add option `--acns-transit-encryption-type <None|WireGuard>` to `az aks create/update`

18.0.0b11
+++++++
* Vendor new SDK and bump API version to 2025-04-02-preview.
Expand Down
4 changes: 4 additions & 0 deletions src/aks-preview/azext_aks_preview/_consts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,10 @@
CONST_ADVANCED_NETWORKPOLICIES_FQDN = "FQDN"
CONST_ADVANCED_NETWORKPOLICIES_L7 = "L7"

# ACNS transit encryption type
CONST_TRANSIT_ENCRYPTION_TYPE_NONE = "None"
CONST_TRANSIT_ENCRYPTION_TYPE_WIREGUARD = "WireGuard"

# network pod ip allocation mode
CONST_NETWORK_POD_IP_ALLOCATION_MODE_DYNAMIC_INDIVIDUAL = "DynamicIndividual"
CONST_NETWORK_POD_IP_ALLOCATION_MODE_STATIC_BLOCK = "StaticBlock"
Expand Down
18 changes: 18 additions & 0 deletions src/aks-preview/azext_aks_preview/_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,8 @@
CONST_ADVANCED_NETWORKPOLICIES_NONE,
CONST_ADVANCED_NETWORKPOLICIES_FQDN,
CONST_ADVANCED_NETWORKPOLICIES_L7,
CONST_TRANSIT_ENCRYPTION_TYPE_NONE,
CONST_TRANSIT_ENCRYPTION_TYPE_WIREGUARD
)

from azext_aks_preview._validators import (
Expand Down Expand Up @@ -320,6 +322,10 @@
CONST_ADVANCED_NETWORKPOLICIES_FQDN,
CONST_ADVANCED_NETWORKPOLICIES_L7,
]
transit_encryption_types = [
CONST_TRANSIT_ENCRYPTION_TYPE_NONE,
CONST_TRANSIT_ENCRYPTION_TYPE_WIREGUARD,
]
network_dataplanes = [CONST_NETWORK_DATAPLANE_AZURE, CONST_NETWORK_DATAPLANE_CILIUM]
disk_driver_versions = [CONST_DISK_DRIVER_V1, CONST_DISK_DRIVER_V2]
outbound_types = [
Expand Down Expand Up @@ -884,6 +890,12 @@ def load_arguments(self, _):
is_preview=True,
arg_type=get_enum_type(advanced_networkpolicies),
)
c.argument(
"acns_transit_encryption_type",
is_preview=True,
arg_type=get_enum_type(transit_encryption_types),
help="Specify the transit encryption type for ACNS. Available values are 'None' and 'WireGuard'.",
)
c.argument(
"enable_retina_flow_logs",
action="store_true",
Expand Down Expand Up @@ -1379,6 +1391,12 @@ def load_arguments(self, _):
is_preview=True,
arg_type=get_enum_type(advanced_networkpolicies),
)
c.argument(
"acns_transit_encryption_type",
is_preview=True,
arg_type=get_enum_type(transit_encryption_types),
help="Specify the transit encryption type for ACNS. Available values are 'None' and 'WireGuard'.",
)
c.argument(
"enable_retina_flow_logs",
action="store_true",
Expand Down
2 changes: 2 additions & 0 deletions src/aks-preview/azext_aks_preview/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -678,6 +678,7 @@ def aks_create(
disable_acns_observability=None,
disable_acns_security=None,
acns_advanced_networkpolicies=None,
acns_transit_encryption_type=None,
enable_retina_flow_logs=None,
# nodepool
crg_id=None,
Expand Down Expand Up @@ -911,6 +912,7 @@ def aks_update(
disable_acns_observability=None,
disable_acns_security=None,
acns_advanced_networkpolicies=None,
acns_transit_encryption_type=None,
enable_retina_flow_logs=None,
disable_retina_flow_logs=None,
# metrics profile
Expand Down
35 changes: 35 additions & 0 deletions src/aks-preview/azext_aks_preview/managed_cluster_decorator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,6 +822,21 @@ def get_acns_advanced_networkpolicies(self) -> Union[str, None]:
)
return self.raw_param.get("acns_advanced_networkpolicies")

def get_acns_transit_encryption_type(self) -> Union[str, None]:
"""Get the value of acns_transit_encryption_type

:return: str or None
"""
disable_acns_security = self.raw_param.get("disable_acns_security")
disable_acns = self.raw_param.get("disable_acns")
acns_transit_encryption_type = self.raw_param.get("acns_transit_encryption_type")
if acns_transit_encryption_type is not None:
if disable_acns_security or disable_acns:
raise MutuallyExclusiveArgumentError(
"--disable-acns-security and --disable-acns cannot be used with --acns-transit-encryption-type."
)
return self.raw_param.get("acns_transit_encryption_type")
Comment thread
nddq marked this conversation as resolved.

def get_retina_flow_logs(self, mc: ManagedCluster) -> Union[bool, None]:
"""Get the enablement of retina flow logs

Expand Down Expand Up @@ -2975,6 +2990,7 @@ def set_up_network_profile(self, mc: ManagedCluster) -> ManagedCluster:
acns = None
(acns_enabled, acns_observability_enabled, acns_security_enabled) = self.context.get_acns_enablement()
acns_advanced_networkpolicies = self.context.get_acns_advanced_networkpolicies()
acns_transit_encryption_type = self.context.get_acns_transit_encryption_type()
if acns_enabled is not None:
acns = self.models.AdvancedNetworking(
enabled=acns_enabled,
Expand All @@ -2994,6 +3010,15 @@ def set_up_network_profile(self, mc: ManagedCluster) -> ManagedCluster:
)
else:
acns.security.advanced_network_policies = acns_advanced_networkpolicies
if acns_transit_encryption_type is not None:
if acns.security is None:
acns.security = self.models.AdvancedNetworkingSecurity(
transit_encryption=self.models.AdvancedNetworkingSecurityTransitEncryption(
type=acns_transit_encryption_type
)
)
else:
acns.security.transit_encryption.type = acns_transit_encryption_type
network_profile.advanced_networking = acns
return mc

Expand Down Expand Up @@ -4064,6 +4089,7 @@ def update_acns_in_network_profile(self, mc: ManagedCluster) -> ManagedCluster:
acns = None
(acns_enabled, acns_observability_enabled, acns_security_enabled) = self.context.get_acns_enablement()
acns_advanced_networkpolicies = self.context.get_acns_advanced_networkpolicies()
acns_transit_encryption_type = self.context.get_acns_transit_encryption_type()
if acns_enabled is not None:
acns = self.models.AdvancedNetworking(
enabled=acns_enabled,
Expand All @@ -4083,6 +4109,15 @@ def update_acns_in_network_profile(self, mc: ManagedCluster) -> ManagedCluster:
)
else:
acns.security.advanced_network_policies = acns_advanced_networkpolicies
if acns_transit_encryption_type is not None:
if acns.security is None:
acns.security = self.models.AdvancedNetworkingSecurity(
transit_encryption=self.models.AdvancedNetworkingSecurityTransitEncryption(
type=acns_transit_encryption_type
)
)
else:
acns.security.transit_encryption.type = acns_transit_encryption_type
mc.network_profile.advanced_networking = acns
return mc

Expand Down
Loading
Loading