Adding azure data transfer commands #8818
Conversation
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Hi @lasuredd-msft, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
There was a problem hiding this comment.
Pull Request Overview
Adds the Azure Data Transfer extension commands and scaffolding for managing connections and flows via the Azure CLI.
- Introduces new
azure-data-transfer connectionandazure-data-transfer connection flowcommand groups with create, delete, list, show, link, and wait operations. - Generates argument stubs (
_params.py) and help entries (_help.py) for all commands. - Adds a placeholder README and initial HISTORY for the extension.
Reviewed Changes
Copilot reviewed 47 out of 47 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/azure-data-transfer/azext_azure_data_transfer/aaz/latest/azure_data_transfer/connection/flow/init.py | Registers “connection flow” subcommands |
| src/azure-data-transfer/azext_azure_data_transfer/_params.py | Stubbed out load_arguments function |
| src/azure-data-transfer/azext_azure_data_transfer/_help.py | Adds help text for new pipeline and connection ops |
| src/azure-data-transfer/azext_azure_data_transfer/README.md | Placeholder usage section |
| src/azure-data-transfer/HISTORY.rst | Initial release history |
Comments suppressed due to low confidence (1)
src/azure-data-transfer/azext_azure_data_transfer/_help.py:52
- [nitpick] The example uses empty values for
--storage-account-nameand--storage-container-name. Provide valid placeholders or remove those flags from the example.
text: az azure-data-transfer connection flow create --resource-group resourceGroup --connection-name connectionName --name flowName --flow-type "Mission" --location WestUs --status "Enabled" --storage-account-id /subscriptions/... --storage-account-name --storage-container-name --data-type "Blob"
|
|
||
|
|
||
| def load_arguments(self, _): # pylint: disable=unused-argument | ||
| pass |
There was a problem hiding this comment.
Currently load_arguments is a no-op, so CLI parameters won’t be registered. Implement argument loading or remove the stub to ensure commands accept their defined arguments.
| pass | |
| with self.argument_context('azure-data-transfer') as c: | |
| c.argument('source', options_list=['--source'], help='The source location for the data transfer.') | |
| c.argument('destination', options_list=['--destination'], help='The destination location for the data transfer.') | |
| c.argument('overwrite', options_list=['--overwrite'], action='store_true', help='Overwrite existing files at the destination.') |
| This is an extension to Azure CLI to manage AzureDataTransfer resources. | ||
|
|
||
| ## How to use ## | ||
| Please add commands usage here. No newline at end of file |
There was a problem hiding this comment.
The README usage section is a placeholder. Add actual usage examples or remove the placeholder text before publishing the extension.
|
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.