{AKS} Wrap the ARG call logic in the managed namespace list command#8825
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks namespace list | cmd aks namespace list update parameter cluster_name: removed property required=True |
||
| aks namespace list | cmd aks namespace list update parameter resource_group_name: removed property required=True |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull Request Overview
Adds support for listing managed namespaces across subscription and resource group scopes, updates related tests and formatting, and bumps extension version.
- Bumps extension version to 18.0.0b9
- Extends
aks namespace listto handle resource group– and subscription-level listings, with new tests - Updates table formatter to handle resources without
propertiesand records change in HISTORY.rst
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/aks-preview/setup.py | Version updated to 18.0.0b9 |
| src/aks-preview/azext_aks_preview/custom.py | Wrapped list logic for RG/cluster vs. subscription scopes |
| src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py | Added tests for RG-only and subscription-level namespace listing |
| src/aks-preview/azext_aks_preview/_format.py | Added branch to format resources lacking properties |
| src/aks-preview/HISTORY.rst | Recorded 18.0.0b9 release entry |
Comments suppressed due to low confidence (2)
src/aks-preview/HISTORY.rst:17
- [nitpick] The history entry uses the term “ARG”, which may be a typo or unclear abbreviation. Consider clarifying whether this refers to ARM or Azure Resource Graph.
* Wrap the ARG call in the managed namespace list command
src/aks-preview/azext_aks_preview/_format.py:96
- The table formatter shows
resourceGroupandlocationonly for resources withoutproperties, but omits them for the default branch. You may want to include consistent columns (e.g.resourceGroup,location) in both cases for a uniform output.
if not result.get("properties"):
|
|
please resolve the code conflict. |
|
[Release] Update index.json for extension [ aks-preview-18.0.0b10 ] : https://dev.azure.com/msazure/One/_build/results?buildId=126204525&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks namespace list
az aks namespace list --resource-group
az aks namespace list --resource-group --cluster-name
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.