[AKS] az aks update: Add --enable-http-proxy option#8826
Merged
yanzhudd merged 8 commits intoAzure:mainfrom Jun 15, 2025
Merged
[AKS] az aks update: Add --enable-http-proxy option#8826yanzhudd merged 8 commits intoAzure:mainfrom
az aks update: Add --enable-http-proxy option#8826yanzhudd merged 8 commits intoAzure:mainfrom
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks update | cmd aks update added parameter enable_http_proxy |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for a new parameter (--enable-http-proxy) in the AKS commands to explicitly enable HTTP proxy configuration for managed clusters.
- Bump the extension version in setup.py from 18.0.0b8 to 18.0.0b9.
- Add new parameter definitions and help entries for enable_http_proxy in _params.py and _help.py.
- Update the decorator logic in managed_cluster_decorator.py and add tests in the test suites to cover the new functionality.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/aks-preview/setup.py | Bumped the version to reflect the new change. |
| src/aks-preview/linter_exclusions.yml | Added linter exclusion for the new enable_http_proxy option. |
| src/aks-preview/azext_aks_preview/tests/latest/test_managed_cluster_decorator.py | Added tests for enabling HTTP proxy configuration. |
| src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py | Added a test case to verify the --enable-http-proxy CLI command behavior. |
| src/aks-preview/azext_aks_preview/managed_cluster_decorator.py | Implemented getter and update methods for enable_http_proxy handling. |
| src/aks-preview/azext_aks_preview/custom.py | Updated function signature to include enable_http_proxy. |
| src/aks-preview/azext_aks_preview/_params.py | Added the CLI argument for enable_http_proxy. |
| src/aks-preview/azext_aks_preview/_help.py | Updated the help documentation to include the new option. |
| src/aks-preview/HISTORY.rst | Documented the change in the extension history. |
Comments suppressed due to low confidence (1)
src/aks-preview/azext_aks_preview/managed_cluster_decorator.py:5359
- Both --disable-http-proxy and --enable-http-proxy flags are checked separately, meaning that if both are set, the enable flag will override the disable flag without notification. Consider adding a mutual exclusion check or clarifying the precedence in documentation to avoid confusion for users.
if self.context.get_enable_http_proxy():
Contributor
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
yanzhudd,
yonzhan and
zhoxing-ms
Contributor
|
github-actions
bot
added
the
release-version-block
Member
|
Please resolve merge conflict |
added 2 commits
June 5, 2025 15:05
Contributor
Author
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
|
The github actions somehow got stuck, could you push an empty commit to trigger the CI again? |
yanzhudd
changed the title
az aks update: Add --enable-http-proxy option
added 2 commits
June 10, 2025 10:04
github-actions
bot
removed
the
release-version-block
Contributor
|
please resolve the code conflict. |
FumingZhang
approved these changes
Jun 15, 2025
yanzhudd
approved these changes
Jun 15, 2025
Collaborator
|
[Release] Update index.json for extension [ aks-preview-18.0.0b13 ] : https://dev.azure.com/msazure/One/_build/results?buildId=127357055&view=results |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks update --enable-http-proxy
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.