Andborja/33153715 add namespace param#8831
Conversation
* forcedelete * format * add code owner * mypy
* Add parameterization for the airgapped clouds * Fix azdev style * MCR path function * azdev, ruff, and mypy --------- Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com>
Co-authored-by: mmcneal <mmcneal@microsoft.com>
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Hi @andborja, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the connectedk8s extension code and test suite to add support for a new namespace parameter while standardizing the use of CLICommand. Key changes include updating CLICommmand to CLICommand across the codebase, adding a new "--kube-namespace" argument, and modifying various test and pipeline scripts accordingly.
Reviewed Changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| testing/Test.ps1 | Introduces the new kube namespace support and updates test execution logic. |
| testing/_params.py | Adds the new "kube_namespace" argument with corresponding help text. |
| src/connectedk8s/azext_connectedk8s/* | Refactors function signatures to use CLICommand and adjusts related proxy, helm, and diagnostic utilities. |
| testing/pipeline/* & .github/CODEOWNERS | Updates pipeline settings and code ownership to support the changes. |
Comments suppressed due to low confidence (1)
src/connectedk8s/azext_connectedk8s/_troubleshootutils.py:359
- The variable 'diagnoser_output' is used here without any prior initialization or declaration in this function's scope, which may lead to a runtime error. Consider initializing it (e.g., as an empty list) or ensuring it is defined in the appropriate scope.
diagnoser_output.append("An exception has occured while trying to fetch the namespace pods logs from the cluster. Exception: {e}\n")
| foreach ($testFile in $testFiles) | ||
| { | ||
| $resultFileNumber++ | ||
| $testName = Split-Path $testFile –leaf |
There was a problem hiding this comment.
The dash in '–leaf' appears to be an en dash instead of a standard hyphen '-'. This might cause parsing issues; please replace it with a normal hyphen.
| $testName = Split-Path $testFile –leaf | |
| $testName = Split-Path $testFile -leaf |
|
Hi @andborja Release SuggestionsModule: connectedk8s
Notes
|
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.