aks-preview: Add new --node-provisioning-default-pools parameter#8857
aks-preview: Add new --node-provisioning-default-pools parameter#8857yanzhudd merged 1 commit intoAzure:mainfrom
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| aks create | cmd aks create added parameter node_provisioning_default_pools |
||
| aks update | cmd aks update added parameter node_provisioning_default_pools |
|
Hi @matthchr, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the new parameter --node-provisioning-default-pools to both the az aks create and update commands.
- Introduces updated tests in test_managed_cluster_decorator.py to verify behavior for unset, "Auto", and "None" values.
- Adds corresponding helper functions in managed_cluster_decorator.py, updates parameter definitions in _params.py, defines new constants in _consts.py, and documents the changes in HISTORY.rst.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/aks-preview/azext_aks_preview/tests/latest/test_managed_cluster_decorator.py | Added tests for node provisioning profile including cases for default pools. |
| src/aks-preview/azext_aks_preview/managed_cluster_decorator.py | Added getter and setter methods for node_provisioning_default_pools in create and update flows. |
| src/aks-preview/azext_aks_preview/_params.py | Introduced new enum values and argument definition for --node-provisioning-default-pools. |
| src/aks-preview/azext_aks_preview/_consts.py | Defined new constants for default pools ("Auto" and "None"). |
| src/aks-preview/HISTORY.rst | Updated changelog to reflect the addition of the new parameter. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Hi @matthchr Release SuggestionsModule: aks-preview
Notes
|
e3675db to
e47815a
Compare
|
whoops forgot to push the style fixes - pushed now |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
FumingZhang
left a comment
There was a problem hiding this comment.
the change looks good to me, it is recommended to add a scenario test for the new feature. You can refer to the existing examples in test_aks_commands.py.
e47815a to
3314bd2
Compare
3314bd2 to
f5ac85c
Compare
|
Added test scenarios, added help text (missed previously), and fixed a few other minor issues. Should be good to merge now. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
FumingZhang
left a comment
There was a problem hiding this comment.
Queued live test to validate the change.
- test_aks_create_node_provisioning_profile
- test_aks_update_node_provisioning_profile
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks createandaz aks updateGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.