[MCC] New Version Commands For Microsoft Connected Cache#8863
[MCC] New Version Commands For Microsoft Connected Cache#8863necusjz merged 7 commits intoAzure:mainfrom
Conversation
❌Azure CLI Extensions Breaking Change Test
|
|
Hi @dcwell, |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the MCC extension commands to use the new 2024-11-30-preview API version and adds several new properties and arguments related to provisioning and cache node configuration.
- Bumped all
api-versionreferences to2024-11-30-preview - Added new schema fields (
drive_configuration,proxy_url_configuration,tlsCertificateProvisioningKey,creationMethod,currentTlsCertificate, etc.) and removed deprecated ones (proxy_url,update_cycle_type) - Introduced a new
--creation-methodargument and cleaned up related arg groups
Reviewed Changes
Copilot reviewed 32 out of 32 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/mcc/azext_mcc/aaz/latest/mcc/isp/node/_get_provisioning_details.py | Version bump and new provisioning schema fields (drive_configuration, proxy_url_configuration, TLS). |
| src/mcc/azext_mcc/aaz/latest/mcc/ent/resource/_list.py | Version bump, swapped list-by-subscription vs list-by-resource-group logic, fixed class names. |
| src/mcc/azext_mcc/aaz/latest/mcc/ent/node/_update.py | Added creation_method argument in multiple commands; removed old flags; updated content mappings. |
Comments suppressed due to low confidence (3)
src/mcc/azext_mcc/aaz/latest/mcc/isp/node/_get_provisioning_details.py:196
- You've added
drive_configuration,proxy_url_configuration, andtlsCertificateProvisioningKeyfields to the provisioning schema—consider adding or updating unit tests to cover serialization and deserialization of these new properties.
properties.drive_configuration = AAZListType(
src/mcc/azext_mcc/aaz/latest/mcc/ent/resource/_list.py:51
- The original logic distinguished between listing by resource group vs subscription, but here the conditions are inverted and the method calls swapped. Please restore the original intent: use
has_value(resource_group)to call the ResourceGroup operation and otherwise call the Subscription operation.
condition_0 = has_value(self.ctx.subscription_id) and has_value(self.ctx.args.resource_group) is not True
src/mcc/azext_mcc/aaz/latest/mcc/ent/node/_update.py:76
- [nitpick] The
creation_methodargument is duplicated across multiple commands (create, update). Consider extracting it into a shared helper or base argument schema to reduce duplication and improve maintainability.
_args_schema.creation_method = AAZIntArg(
| return result, next_link | ||
|
|
||
| class EnterpriseMccCustomersListByResourceGroup(AAZHttpOperation): | ||
| class EnterpriseMccCustomersListBySubscription(AAZHttpOperation): |
There was a problem hiding this comment.
The class names for the HTTP handlers were swapped. The URL /providers/Microsoft.ConnectedCache/enterpriseMccCustomers should be implemented by the Subscription class, and the resource-group path by the ResourceGroup class. Please rename them to match their actual endpoints.
| class EnterpriseMccCustomersListBySubscription(AAZHttpOperation): | |
| class EnterpriseMccCustomersListByResourceGroup(AAZHttpOperation): |
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
@dcwell would you mind update it? |
…ed VERSION to 1.0.0b3 in setup.py.
@necusjz I have updated with the suggested changes. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@dcwell could you plz provide the link of your pull request in Azure/aaz? |
|
@necusjz @kairu-ms Please re-review this PR. I have added more changes based on changing requirements for our product. Latest iteration is final. Here is the AAZ repo PR associated with this: |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 8863 in repo Azure/azure-cli-extensions |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
[CLI][Extensions][mcc][v1.0.0b3] AAZ PR Pair for Azure/azure-cli-extensions#8863
|
[Release] Update index.json for extension [ mcc-1.0.0b3 ] : https://dev.azure.com/msazure/One/_build/results?buildId=128342126&view=results |
…ache.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.