Skip to content

Adding local dns profile to az aks nodepool update#8880

Merged
zhoxing-ms merged 61 commits intoAzure:mainfrom
anushkasingh16:anushkasingh/local-dns-cli-extension
Jul 21, 2025
Merged

Adding local dns profile to az aks nodepool update#8880
zhoxing-ms merged 61 commits intoAzure:mainfrom
anushkasingh16:anushkasingh/local-dns-cli-extension

Conversation

@anushkasingh16
Copy link
Copy Markdown
Contributor

@anushkasingh16 anushkasingh16 commented Jun 20, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Jun 20, 2025

❌Azure CLI Extensions Breaking Change Test
❌aks-preview
rule cmd_name rule_message suggest_message
1010 - ParaPropUpdate aks nodepool add cmd aks nodepool add update parameter spot_max_price: updated property default from nan to nan please change property default from nan to nan for parameter spot_max_price of cmd aks nodepool add
⚠️ 1006 - ParaAdd aks nodepool add cmd aks nodepool add added parameter localdns_config
⚠️ 1006 - ParaAdd aks nodepool update cmd aks nodepool update added parameter localdns_config

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @anushkasingh16,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Jun 20, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown
Contributor

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 20, 2025

Comment thread src/aks-preview/azext_aks_preview/_consts.py Outdated
Comment thread src/aks-preview/azext_aks_preview/_consts.py Outdated
Comment thread src/aks-preview/azext_aks_preview/_consts.py Outdated
@anushkasingh16 anushkasingh16 marked this pull request as ready for review June 20, 2025 21:18
@FumingZhang
Copy link
Copy Markdown
Member

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

Comment thread src/aks-preview/azext_aks_preview/_params.py Outdated
Comment thread src/aks-preview/azext_aks_preview/_params.py Outdated
Comment thread src/aks-preview/azext_aks_preview/agentpool_decorator.py Outdated
@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

@FumingZhang
Copy link
Copy Markdown
Member

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

Comment thread src/aks-preview/HISTORY.rst Outdated
Comment thread src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py Outdated
Comment thread src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py Outdated
@FumingZhang
Copy link
Copy Markdown
Member

The failed test cases in Azure.azure-cli-extensions (Integration Tests, Build Tests Python39) is not related to the change.

FAILED src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py::AzureKubernetesServiceScenarioTest::test_aks_approuting_enable_with_keyvault_secrets_provider_addon_and_keyvault_id
FAILED src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py::AzureKubernetesServiceScenarioTest::test_aks_managed_namespace

Fixing the issue in a separate PR #8975

@anushkasingh16
Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Commenter does not have sufficient privileges for PR 8880 in repo Azure/azure-cli-extensions

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Jul 17, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

FumingZhang
FumingZhang previously approved these changes Jul 18, 2025
Comment thread src/aks-preview/HISTORY.rst Outdated
Comment thread src/aks-preview/azext_aks_preview/_help.py
Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
Comment thread src/aks-preview/HISTORY.rst Outdated
Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
@FumingZhang
Copy link
Copy Markdown
Member

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

@FumingZhang
Copy link
Copy Markdown
Member

@microsoft-github-policy-service rerun

@zhoxing-ms zhoxing-ms merged commit c33bc89 into Azure:main Jul 21, 2025
24 checks passed
@azclibot
Copy link
Copy Markdown
Collaborator

[Release] Update index.json for extension [ aks-preview-18.0.0b19 ] : https://dev.azure.com/msazure/One/_build/results?buildId=131024038&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants