Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @evelyn-ys, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Purview account test recording to mask secret keys, preventing sensitive data from appearing in playback.
- Replaced raw
SharedAccessKeyvalues with masked placeholders in the test YAML.
Comments suppressed due to low confidence (1)
src/purview/azext_purview/tests/latest/recordings/test_purview_account.yaml:625
- [nitpick] Consider using the Azure CLI test framework’s recording processors (e.g.,
RecordingProcessorormask_secret) to automatically mask sensitive values instead of manually editing recordings—this ensures consistency and reduces maintenance overhead.
string: '{"atlasKafkaPrimaryEndpoint":"Endpoint=sb://atlas-f553921a-9b69-4405-b43f-2e6879ce750d.servicebus.windows.net/;SharedAccessKeyName=AlternateSharedAccessKey;SharedAccessKey=********************************************","atlasKafkaSecondaryEndpoint":"Endpoint=sb://atlas-f553921a-9b69-4405-b43f-2e6879ce750d.servicebus.windows.net/;SharedAccessKeyName=AlternateSharedAccessKey;SharedAccessKey=********************************************"}'
|
The secrets in purview test recording file should already be invalid. This PR is just to make repo clean
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.