{AKS} fix test case when AGIC with Azure CNI Overlay#8902
{AKS} fix test case when AGIC with Azure CNI Overlay#8902yanzhudd merged 3 commits intoAzure:mainfrom
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @robogatikov, |
There was a problem hiding this comment.
Pull Request Overview
This PR updates an existing test to align with the requirement that the App Gateway subnet CIDR must be shorter than /24 when AGIC is enabled in an Azure CNI Overlay cluster.
- Changed the
--appgw-subnet-cidrvalue from/16to/26in the test command. - Updated the expected assertion for the subnetCIDR check to
/26.
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
89a21a9 to
8606c0d
Compare
There was a problem hiding this comment.
Queued live test to validate the change, test passed!
- test_aks_create_with_ingress_appgw_addon
This checklist is used to make sure that common guidelines for a pull request are followed.
When Ingress Appgateway Addon is enabled in Azure CNI Overlay cluster and
--uppgw-subnet-cidris specified on cluster create, the cidr should be shorter than /24.Related command
az aks createGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.