{AKS} udpate description for --pod-cidr and --pod-cidrs#8913
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @robogatikov, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the help text for the --pod-cidr and --pod-cidrs flags in the AKS preview extension to reference the new Azure CNI Overlay mode and Kubenet’s planned retirement.
- Updated short and long summaries for
--pod-cidrto include Azure CNI Overlay context and Kubenet deprecation date. - Mirrored those changes for
--pod-cidrs, adding a link to the Azure CNI Overlay docs. - Added
aka.ms/aks/azure-cni-overlayreference in both long summaries.
Comments suppressed due to low confidence (2)
src/aks-preview/azext_aks_preview/_help.py:243
- [nitpick] Consider moving the Kubenet retirement note out of the short-summary into the long-summary for clarity, and adjust casing for consistency (e.g., lowercase 'kubenet' to match existing entries and use lowercase 'on' within parentheses).
short-summary: A CIDR notation IP range from which to assign pod IPs when Azure CNI Overlay or Kubenet is used (On 31 March 2028, Kubenet will be retired).
src/aks-preview/azext_aks_preview/_help.py:255
- [nitpick] As above, consider relocating the retirement note to the long-summary and normalizing casing (e.g., lowercase 'kubenet' and 'on') to improve readability and consistency across help entries.
short-summary: A comma-separated list of CIDR notation IP ranges from which to assign pod IPs when Azure CNI Overlay or Kubenet is used (On 31 March 2028, Kubenet will be retired).
|
Hi @robogatikov Release SuggestionsModule: aks-preview
Notes
|
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks createaz aks updateGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.