Skip to content

[Bug] Fixing Bastion tunnel establishment issue #8916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sabbour wants to merge 6 commits into from
Closed

[Bug] Fixing Bastion tunnel establishment issue #8916

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
156f08b
Fixing Bastion tunnel establishment issue
sabbour Jul 1, 2025
b19cb03
Fixing is_port_open logic
sabbour Jul 1, 2025
3b1356b
Revert "Fixing is_port_open logic"
sabbour Jul 3, 2025
340b3f6
Updated API version in test recording to 2024-07-01
sabbour Jul 3, 2025
02fcc3c
Bump version to 1.4.2 and update HISTORY.rst with bug fix for tunnel
sabbour Jul 3, 2025
5866d33
Update test_bastion_host_crud.yaml
sabbour Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/bastion/azext_bastion/tunnel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,11 @@ def __init__(self, cli_ctx, local_addr, local_port, bastion, bastion_endpoint, r
def is_port_open(self):
is_port_open = False
with closing(socket.socket(socket.AF_INET, socket.SOCK_STREAM)) as sock:
if sock.connect_ex(('', self.local_port)) == 0:
logger.info('Port %s is NOT open', self.local_port)
else:
if sock.connect_ex((self.local_addr, self.local_port)) == 0:
logger.info('Port %s is open', self.local_port)
Comment thread
sabbour marked this conversation as resolved.
is_port_open = True
else:
logger.info('Port %s is NOT open', self.local_port)
Comment thread
sabbour marked this conversation as resolved.
Outdated
return is_port_open

def _get_auth_token(self):
Expand Down
Loading