{AKS} Fix #8907: Remove deprecated pkg_resources declare namespace#8921
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
yanzhudd,
yonzhan and
zhoxing-ms
There was a problem hiding this comment.
Pull Request Overview
This PR removes a deprecated namespace declaration from the vendored SDK, bumps the extension version, and adds a history entry to reflect the change.
- Bump version to 18.0.0b16 in setup.py
- Remove
pkg_resources.declare_namespacecall fromvendored_sdks/__init__.py - Update HISTORY.rst with a new 18.0.0b16 entry
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/aks-preview/setup.py | Version updated from 18.0.0b15 to 18.0.0b16 |
| src/aks-preview/azext_aks_preview/vendored_sdks/init.py | Removed deprecated namespace declaration |
| src/aks-preview/HISTORY.rst | Added new version header and change note |
Comments suppressed due to low confidence (1)
|
FumingZhang
force-pushed
the
fuming/fix-namespace-pkg-0702
branch
from
d0b5b75 to
c0ea336
Compare
|
[Release] Update index.json for extension [ aks-preview-18.0.0b17 ] : https://dev.azure.com/msazure/One/_build/results?buildId=129214573&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
{AKS} Fix #8907: Remove deprecated pkg_resources declare namespace
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.