{AKS} fix test_aks_create_update_fips_flow by specifying non-arm64 vm size#8935
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @calvin197, |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the FIPS preview test to explicitly use a non-ARM VM size for both initial cluster creation and secondary node pool operations.
- Add
--node-vm-size Standard_D2s_v3to theaks createcommand - Add
--node-vm-size Standard_D2s_v3to the secondary node pool creation command
| # 1. create | ||
| create_cmd = ( | ||
| "aks create --resource-group={resource_group} --name={name} --location={location} " | ||
| "aks create --resource-group={resource_group} --name={name} --location={location} --node-vm-size Standard_D2s_v3 " |
There was a problem hiding this comment.
[nitpick] The VM size 'Standard_D2s_v3' is repeated; consider extracting it to a named constant or test variable and adding a comment explaining why this specific size is required for the FIPS preview flow, which will improve readability and reduce duplication.
| "--resource-group={resource_group} " | ||
| "--cluster-name={name} " | ||
| "--name={node_pool_name_second} " | ||
| "--node-vm-size Standard_D2s_v3 " |
There was a problem hiding this comment.
[nitpick] Duplicate literal 'Standard_D2s_v3' here as well; extracting to a shared variable or constant would make updates easier and ensure consistency across the test.
| "--node-vm-size Standard_D2s_v3 " | |
| f"--node-vm-size {self.DEFAULT_NODE_VM_SIZE} " |
calvin197
changed the title
|
Makes sense to me. Would be good to run tests to see it fixing failure rate |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
calvin197
changed the title
There was a problem hiding this comment.
Queued live test to validate the change, test passed!
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
aks create --enable-fips-image
aks nodepool add --enable-fips-image
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.