register command group for security-policy waf#8936
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Pull Request Overview
This PR registers a new command group for WAF security policies under the network alb security-policy waf namespace and updates versioning.
- Bumps extension version to 2.0.1
- Adds the
network alb security-policy wafcommand group incustom.py - Updates
HISTORY.rstwith the 2.0.1 release entry
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/alb/setup.py | Updated VERSION from '2.0.0' to '2.0.1' |
| src/alb/azext_alb/custom.py | Introduced @register_command_group and class for WAF security policies |
| src/alb/HISTORY.rst | Added 2.0.1 release notes entry |
Comments suppressed due to low confidence (2)
src/alb/azext_alb/custom.py:37
- [nitpick] The class name
__CMDGroupis ambiguous; consider renaming it to something more descriptive likeWafSecurityPolicyCommandGroupto improve readability.
class __CMDGroup(AAZCommandGroup):
src/alb/azext_alb/custom.py:36
- Consider adding or updating tests to cover the new
network alb security-policy wafcommand group to ensure its commands are correctly registered and invoked.
@register_command_group("network alb security-policy waf")
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
Hi @cdxu-147
|
|
Commenter does not have sufficient privileges for PR 8936 in repo Azure/azure-cli-extensions |
|
@cdxu-147 let's modify |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
c2b7dff to
85d889b
Compare
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
[Release] Update index.json for extension [ alb-2.0.1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=129880641&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az network alb security-policy waf
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.