Skip to content

add additional validations for commands az aks extension type list and az aks extension type version list #8937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yanzhudd merged 11 commits into from
Jul 4, 2025
Merged

add additional validations for commands az aks extension type list and az aks extension type version list #8937

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
172bf90
add troubleshoot command under connectedk8s
Mar 25, 2021
29a8518
resolve check issues
Mar 25, 2021
fe3c1e8
fix final new line
Mar 25, 2021
be0e8cd
add back troubleshoot params
Mar 25, 2021
18059a8
implement helm version and permission checks
Apr 5, 2021
9db15cd
Merge branch 'main' of https://github.com/Azure/azure-cli-extensions
Apr 7, 2025
b37e4b6
Merge branch 'main' of https://github.com/Azure/azure-cli-extensions
Apr 23, 2025
1a5df59
Merge branch 'main' of https://github.com/Azure/azure-cli-extensions
Jul 3, 2025
6261f16
add validation error
Jul 3, 2025
7e29c0b
revert connectedk8s changes
Jul 3, 2025
a9c68ba
remove newline
Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/aks-preview/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ To release a new version, please select a new version number (usually plus 1 to

Pending
+++++++
18.0.0b18
+++++++
* Add validation error when neither --location or --cluster and --resource-group-name are specified for az extension type list or az extension type version list
Copy link

Copilot AI Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The phrasing is unclear. Consider rewording to: “Add validation error when neither --location nor both --cluster and --resource-group-name are specified.”

Suggested change
* Add validation error when neither --location or --cluster and --resource-group-name are specified for az extension type list or az extension type version list
* Add validation error when neither --location nor both --cluster and --resource-group-name are specified for az extension type list or az extension type version list

Copilot uses AI. Check for mistakes.


18.0.0b17
+++++++
Expand Down
4 changes: 4 additions & 0 deletions src/aks-preview/azext_aks_preview/_validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -964,6 +964,10 @@ def validate_location_resource_group_cluster_parameters(namespace):
location = namespace.location
resource_group_name = namespace.resource_group_name
cluster_name = namespace.cluster_name
if not namespace.location and not namespace.cluster_name and not namespace.resource_group_name:
Copy link

Copilot AI Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This condition only fires when all three flags are missing. It doesn’t catch cases where only one of --resource-group-name or --cluster is provided without the other. Consider adding a separate check to require both or to use XOR logic when location is absent.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Member

@matthchr matthchr Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That check already exists below...

raise RequiredArgumentMissingError(
"You must specify --location or --resource-group and --cluster."
)
if location and (resource_group_name or cluster_name):
raise RequiredArgumentMissingError(
"You must specify --location or --resource-group and --cluster."
Expand Down
2 changes: 1 addition & 1 deletion src/aks-preview/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

from setuptools import setup, find_packages

VERSION = "18.0.0b17"
VERSION = "18.0.0b18"

CLASSIFIERS = [
"Development Status :: 4 - Beta",
Expand Down
8 changes: 7 additions & 1 deletion src/connectedk8s/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,10 @@ or
az connectedk8s delete \
--ids "/subscriptions/subscription_id/resourceGroups/my-rg/providers/Microsoft.Kubernetes/connectedClusters/my-cluster" \
-y
```
```

#### Troubleshoot and get logs for a broken cluster
```
az connectedk8s troubleshoot \
--resource-group my-rg \
--name my-cluster \
26 changes: 26 additions & 0 deletions src/connectedk8s/azext_connectedk8s/troubleshoot.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
[
{
"Check": "HelmInstallation",
"Condition": "true",
"Method": "check_helm_installed",
"PassMessage": "Helm installation check passed!",
"FailMessage": "Helm not found. Please install the latest version of Helm. Learn more at https://aka.ms/arc/k8s/onboarding-helm-install",
"Enabled": "true"
},
{
"Check": "HelmVersion",
"Condition": ">=version.parse(\"3.0\")",
"Method": "check_helm_3",
"PassMessage": "Your Helm version is up to date!",
"FailMessage": "Helm 3+ required. Please visit https://aka.ms/arc/k8s/onboarding-helm-install to download the latest installation of Helm.",
"Enabled": "true"
},
{
"Check": "AzurePermissionCheck",
"Condition": "true",
"Method": "check_azure_folder_permissions",
"PassMessage": "You have the correct permissions!",
"FailMessage": "Please use the following command to get the correct permissions: ",
"Enabled": "true"
}
]
Loading