add Fleet 04-01 api CLI support#8938
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| fleet autoupgradeprofile create | cmd fleet autoupgradeprofile create added parameter long_term_support |
||
| fleet autoupgradeprofile create | cmd fleet autoupgradeprofile create added parameter target_kubernetes_version |
||
| fleet autoupgradeprofile create | cmd fleet autoupgradeprofile create update parameter channel: updated property choices from ['NodeImage', 'Rapid', 'Stable'] to ['NodeImage', 'Rapid', 'Stable', 'TargetKubernetesVersion'] |
||
| fleet gate | sub group fleet gate added |
||
| fleet member create | cmd fleet member create added parameter member_labels |
||
| fleet member update | cmd fleet member update added parameter member_labels |
|
Hi @frantran, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds the vendored SDK for the 2025-04-01-preview Fleet API version, including marker files and all operation classes.
- Introduces
py.typedmarker for PEP 561 compliance. - Adds complete operation modules (
_update_runs_operations.py,_gates_operations.py,_fleets_operations.py, etc.) generated by AutoRest. - Includes a customization entry point in
_patch.py.
Reviewed Changes
Copilot reviewed 38 out of 39 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| py.typed | PEP 561 marker file |
_update_runs_operations.py |
Full CRUD and LRO support for UpdateRun resources |
_patch.py |
SDK customization entry point |
_operations.py |
Core provider operations |
_gates_operations.py |
Operations for Gate resources |
_fleets_operations.py |
Operations for Fleet resources |
_fleet_update_strategies_operations.py |
Operations for FleetUpdateStrategy resources |
Comments suppressed due to low confidence (2)
src/fleet/azext_fleet/vendored_sdks/v2025_04_01_preview/operations/_patch.py:12
- [nitpick] The
__all__list is empty, which means no symbols are publicly exposed at this level. Either populate it with the intended public customizations or remove it to avoid confusion.
__all__: List[str] = [] # Add all objects you want publicly available to users at this package level
src/fleet/azext_fleet/vendored_sdks/v2025_04_01_preview/operations/_update_runs_operations.py:1449
- The generated UpdateRuns operations are not covered by any tests. Adding unit or integration tests for methods like
list_by_fleet,get, and the LRO variants will help catch regressions.
)
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 8938 in repo Azure/azure-cli-extensions |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Please fix CI issues |
There was a problem hiding this comment.
In src/fleet/azext_fleet/custom.py, method get_update_run_strategy, lines 485-496, we also need to parse the before/afterGates JSON and include those structures in the group and stage models.
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
[Release] Update index.json for extension [ fleet-1.6.0 ] : https://dev.azure.com/msazure/One/_build/results?buildId=132088636&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az fleet ....General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.