[fleet] configure sdk 2025-04-01-preview#8939
Conversation
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Hi @serbrech, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds the vendored SDK for the Fleet extension targeting the 2025-04-01-preview API version, including generated operation modules and a PEP 561 marker file.
- Added
py.typedmarker to enable typing for the vendored SDK - Introduced generated operation modules (
_update_runs_operations.py,_fleets_operations.py, etc.) - Included placeholder customization file (
_patch.py) for future SDK tweaks
Reviewed Changes
Copilot reviewed 43 out of 44 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/fleet/azext_fleet/vendored_sdks/v2025_04_01_preview/py.typed | Added PEP 561 marker file |
| src/fleet/azext_fleet/vendored_sdks/v2025_04_01_preview/operations/_update_runs_operations.py | Generated operations for updateRuns |
| src/fleet/azext_fleet/vendored_sdks/v2025_04_01_preview/operations/_patch.py | Placeholder for SDK customizations |
Comments suppressed due to low confidence (1)
src/fleet/azext_fleet/vendored_sdks/v2025_04_01_preview/operations/_update_runs_operations.py:410
- Consider adding unit or integration tests for
list_by_fleet(and other new methods likebegin_create_or_update,begin_skip, etc.) to verify correct URL building, parameter handling, and paging.
def list_by_fleet(self, resource_group_name: str, fleet_name: str, **kwargs: Any) -> ItemPaged["_models.UpdateRun"]:
| """ | ||
| from typing import List | ||
|
|
||
| __all__: List[str] = [] # Add all objects you want publicly available to users at this package level |
There was a problem hiding this comment.
Populate __all__ with 'patch_sdk' (or other intended exports) so that users can import the customization function directly.
| __all__: List[str] = [] # Add all objects you want publicly available to users at this package level | |
| __all__: List[str] = ['patch_sdk'] # Add all objects you want publicly available to users at this package level |
|
Hi @serbrech Release SuggestionsModule: fleet
Notes
|
|
OK. Let me close this RP |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.