Pure Storage Block commands onboarding#8945
Pure Storage Block commands onboarding#8945deepakmauryams wants to merge 17 commits intoAzure:mainfrom
Conversation
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Hi @deepakmauryams, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
There was a problem hiding this comment.
Pull Request Overview
Adds the initial scaffolding for the Purestorageblock Azure CLI extension, including packaging, command modules, and test placeholders
- Defines extension metadata and dependencies in setup.py and setup.cfg
- Generates AAZ‐based command groups and operations for storage pool, AVS VM, and container resources
- Adds a placeholder test file with a TODO for future tests
Reviewed Changes
Copilot reviewed 69 out of 69 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/purestorageblock/setup.py | Package metadata and entry point configuration |
| src/purestorageblock/setup.cfg | Empty configuration file added |
| src/purestorageblock/azext_purestorageblock/commands.py | Stubbed load_command_table with no implementation |
| src/purestorageblock/azext_purestorageblock/tests/latest/test_purestorageblock.py | Placeholder test class with TODO |
Comments suppressed due to low confidence (1)
src/purestorageblock/azext_purestorageblock/tests/latest/test_purestorageblock.py:13
- No tests are implemented (marked TODO), leaving core functionality unverified. Please add scenario tests to cover the extension commands.
pass
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 8945 in repo Azure/azure-cli-extensions |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.