Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @reneeli123, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull Request Overview
This PR restores the previously disabled end-to-end test for migrating AKS clusters from Availability Set (VMAS) to Virtual Machines (VMs).
- Uncomments and reactivates the
test_aks_migrate_vmas_to_vmsmethod, including its decorators. - Reinstates the cluster creation, migration update, and deletion commands within the test.
Comments suppressed due to low confidence (1)
|
FumingZhang
left a comment
There was a problem hiding this comment.
Live test passed!
- test_aks_migrate_vmas_to_vms
b2193d3 to
02307ff
Compare
|
Please fix CI issues |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks update --migrate-vmas-to-vms
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.