{AKS} az aks update: Fix the bug affecting VMAS to VMS migration#8997
{AKS} az aks update: Fix the bug affecting VMAS to VMS migration#8997zhoxing-ms merged 4 commits intoAzure:mainfrom
az aks update: Fix the bug affecting VMAS to VMS migration#8997Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the VMAS to VMS migration functionality within the az aks update command. The fix addresses an issue where the migration validation was too restrictive, preventing valid migration scenarios from proceeding.
Key changes:
- Updated version number from 18.0.0b19 to 18.0.0b20
- Modified the agent pool type validation logic to accept both CONST_AVAILABILITY_SET and CONST_VIRTUAL_MACHINES types
- Added corresponding entry to the changelog documenting the bug fix
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| setup.py | Version bump to 18.0.0b20 |
| managed_cluster_decorator.py | Fixed validation logic for VMAS to VMS migration to accept additional valid agent pool types |
| HISTORY.rst | Updated changelog with bug fix description and reorganized version entries |
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
[Release] Update index.json for extension [ aks-preview-18.0.0b20 ] : https://dev.azure.com/msazure/One/_build/results?buildId=131608261&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
{AKS}
az aks update: Fix the bug affecting VMAS to VMS migration. The code recently added to official azure-cli is updating the value of nodepool type earlier than the code in aks-preview, leading to the following error. The fix is to slightly relax the check conditions in aks-preview.az aks update: Support VMAS to VMS agent pool migration in AKS commands azure-cli#31831General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.