Skip to content

{AKS} az aks update: Fix the bug affecting VMAS to VMS migration#8997

Merged
zhoxing-ms merged 4 commits intoAzure:mainfrom
FumingZhang:fuming/fix-vmas-migration-0724
Jul 25, 2025
Merged

{AKS} az aks update: Fix the bug affecting VMAS to VMS migration#8997
zhoxing-ms merged 4 commits intoAzure:mainfrom
FumingZhang:fuming/fix-vmas-migration-0724

Conversation

@FumingZhang
Copy link
Copy Markdown
Member

@FumingZhang FumingZhang commented Jul 24, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

{AKS} az aks update: Fix the bug affecting VMAS to VMS migration. The code recently added to official azure-cli is updating the value of nodepool type earlier than the code in aks-preview, leading to the following error. The fix is to slightly relax the check conditions in aks-preview.

          raise CLIError('This is not a valid VMAS cluster, we cannot proceed with the migration.')

E knack.util.CLIError: This is not a valid VMAS cluster, we cannot proceed with the migration.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings July 24, 2025 04:56
@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Jul 24, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@github-actions
Copy link
Copy Markdown
Contributor

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Jul 24, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in the VMAS to VMS migration functionality within the az aks update command. The fix addresses an issue where the migration validation was too restrictive, preventing valid migration scenarios from proceeding.

Key changes:

  • Updated version number from 18.0.0b19 to 18.0.0b20
  • Modified the agent pool type validation logic to accept both CONST_AVAILABILITY_SET and CONST_VIRTUAL_MACHINES types
  • Added corresponding entry to the changelog documenting the bug fix

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
setup.py Version bump to 18.0.0b20
managed_cluster_decorator.py Fixed validation logic for VMAS to VMS migration to accept additional valid agent pool types
HISTORY.rst Updated changelog with bug fix description and reorganized version entries

Comment thread src/aks-preview/HISTORY.rst Outdated
Comment thread src/aks-preview/HISTORY.rst Outdated
@github-actions
Copy link
Copy Markdown
Contributor

FumingZhang and others added 2 commits July 24, 2025 18:00
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@zhoxing-ms zhoxing-ms merged commit 106c12c into Azure:main Jul 25, 2025
24 checks passed
@azclibot
Copy link
Copy Markdown
Collaborator

[Release] Update index.json for extension [ aks-preview-18.0.0b20 ] : https://dev.azure.com/msazure/One/_build/results?buildId=131608261&view=results

@FumingZhang FumingZhang deleted the fuming/fix-vmas-migration-0724 branch September 10, 2025 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants