{AKS} Suppress the annoying message if the cluster sku name is automatic#9019
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @xmzhao0822, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the SSH access warning message behavior in the AKS agent pool decorator to suppress a specific warning when the cluster SKU is set to "automatic".
- Updates the
set_up_ssh_accessmethod to check the cluster SKU name and display different warning messages - Adds corresponding unit tests to verify the warning message behavior for both "automatic" and "base" SKU types
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| agentpool_decorator.py | Modified SSH access warning logic to show different messages based on cluster SKU type |
| test_agentpool_decorator.py | Added unit tests to verify warning message behavior for automatic and base SKU types |
Comments suppressed due to low confidence (1)
src/aks-preview/azext_aks_preview/tests/latest/test_agentpool_decorator.py:116
- The test is checking for the exact warning message string. If the message is updated (as suggested above), this test will need to be updated as well. Consider using a more flexible assertion or storing the expected message in a constant to maintain consistency.
)
|
There was a problem hiding this comment.
Queued live test to validate the change, test passed!
|
Could you please resolve these conflicts? |
Resolved the conflict in History, please approve again, thanks |
|
[Release] Update index.json for extension [ aks-preview-18.0.0b24 ] : https://dev.azure.com/msazure/One/_build/results?buildId=132350762&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks create -g rg -n mc --sku automatic
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.