Skip to content

{AKS} Suppress the annoying message if the cluster sku name is automatic#9019

Merged
zhoxing-ms merged 6 commits intoAzure:mainfrom
xmzhao0822:xmzhao/suppress-ssh-access-message-for-automatic
Aug 1, 2025
Merged

{AKS} Suppress the annoying message if the cluster sku name is automatic#9019
zhoxing-ms merged 6 commits intoAzure:mainfrom
xmzhao0822:xmzhao/suppress-ssh-access-message-for-automatic

Conversation

@xmzhao0822
Copy link
Copy Markdown
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks create -g rg -n mc --sku automatic

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings July 29, 2025 20:52
@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Jul 29, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @xmzhao0822,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Jul 29, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown
Contributor

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the SSH access warning message behavior in the AKS agent pool decorator to suppress a specific warning when the cluster SKU is set to "automatic".

  • Updates the set_up_ssh_access method to check the cluster SKU name and display different warning messages
  • Adds corresponding unit tests to verify the warning message behavior for both "automatic" and "base" SKU types

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
agentpool_decorator.py Modified SSH access warning logic to show different messages based on cluster SKU type
test_agentpool_decorator.py Added unit tests to verify warning message behavior for automatic and base SKU types
Comments suppressed due to low confidence (1)

src/aks-preview/azext_aks_preview/tests/latest/test_agentpool_decorator.py:116

  • The test is checking for the exact warning message string. If the message is updated (as suggested above), this test will need to be updated as well. Consider using a more flexible assertion or storing the expected message in a constant to maintain consistency.
        )

Comment thread src/aks-preview/azext_aks_preview/agentpool_decorator.py Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 29, 2025

Comment thread src/aks-preview/azext_aks_preview/agentpool_decorator.py Outdated
Comment thread src/aks-preview/azext_aks_preview/agentpool_decorator.py Outdated
Copy link
Copy Markdown
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queued live test to validate the change, test passed!

FumingZhang
FumingZhang previously approved these changes Jul 31, 2025
zhoxing-ms
zhoxing-ms previously approved these changes Jul 31, 2025
@zhoxing-ms
Copy link
Copy Markdown
Contributor

Could you please resolve these conflicts?

@xmzhao0822
Copy link
Copy Markdown
Contributor Author

Could you please resolve these conflicts?

Resolved the conflict in History, please approve again, thanks

@zhoxing-ms zhoxing-ms merged commit 4030a8e into Azure:main Aug 1, 2025
24 checks passed
@azclibot
Copy link
Copy Markdown
Collaborator

azclibot commented Aug 1, 2025

[Release] Update index.json for extension [ aks-preview-18.0.0b24 ] : https://dev.azure.com/msazure/One/_build/results?buildId=132350762&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants