Skip to content

{Acrcssc} Fix resource SDK import error #9041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kairu-ms merged 1 commit into from
Aug 6, 2025
Merged

{Acrcssc} Fix resource SDK import error #9041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/acrcssc/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

Release History
===============

1.0.0b4
+++++++
* Fix resource SDK import error

1.0.0b3
+++++++
* Remove msrestazure dependency
Expand Down
2 changes: 1 addition & 1 deletion src/acrcssc/azext_acrcssc/azext_metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"azext.isPreview": true,
"azext.minCliCoreVersion": "2.60.0"
"azext.minCliCoreVersion": "2.76.0"
}
2 changes: 1 addition & 1 deletion src/acrcssc/azext_acrcssc/helper/_deployment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
from azure.cli.core.util import get_file_json
from azure.cli.core.azclierror import AzCLIError
from azure.cli.core.commands import LongRunningOperation
from azure.mgmt.resource.resources.models import (
from azure.mgmt.resource.deployments.models import (
Copy link

Copilot AI Aug 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When working with Azure SDK imports, ensure this import path aligns with Azure best practices for the target CLI version. The change from 'resources.models' to 'deployments.models' should be verified against the Azure SDK documentation for version 2.76.0.

Copilot generated this review using guidance from repository custom instructions.
DeploymentExtended,
DeploymentProperties,
DeploymentMode,
Expand Down
2 changes: 1 addition & 1 deletion src/acrcssc/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
from distutils import log as logger
logger.warn("Wheel is not available, disabling bdist_wheel hook")

VERSION = '1.0.0b3'
VERSION = '1.0.0b4'

# The full list of classifiers is available at
# https://pypi.python.org/pypi?%3Aaction=list_classifiers
Expand Down
Loading