Conversation
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Hi @deepakmauryams, |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new Azure CLI extension for managing Pure Storage Cloud Block resources. The extension provides comprehensive management capabilities for both reservations and storage pools through command-line interface.
- Creates a new CLI extension called "pscloud" for managing Pure Storage Block resources
- Implements commands for managing reservations (create, update, delete, show, list, wait)
- Implements commands for managing storage pools (create, update, delete, show, list, wait, health status, AVS status)
Reviewed Changes
Copilot reviewed 33 out of 33 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/pscloud/setup.py | Package setup configuration for the pscloud extension |
| src/pscloud/azext_pscloud/init.py | Extension loader and command registration infrastructure |
| src/pscloud/azext_pscloud/commands.py | Command table loader entry point |
| src/pscloud/azext_pscloud/aaz/latest/pscloud/*.py | AAZ-generated command implementations for reservation management |
| src/pscloud/azext_pscloud/aaz/latest/pscloud/pool/*.py | AAZ-generated command implementations for storage pool management |
| src/pscloud/azext_pscloud/tests/latest/test_pscloud.py | Initial test scaffold for the extension |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
|
AAZ PR - Azure/aaz#828 |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
| _args_schema.mi_system_assigned = AAZStrArg( | ||
| options=["--system-assigned", "--mi-system-assigned"], | ||
| arg_group="Identity", | ||
| help="Set the system managed identity.", | ||
| blank="True", | ||
| ) | ||
| _args_schema.mi_user_assigned = AAZListArg( | ||
| options=["--user-assigned", "--mi-user-assigned"], | ||
| arg_group="Identity", | ||
| help="Set the user managed identities.", | ||
| blank=[], | ||
| ) |
There was a problem hiding this comment.
Those two argument should has sub commands. @necusjz I thought the aaz-dev could generate them atomically
There was a problem hiding this comment.
@deepakmauryams have you removed the subcommands in the workspace ui?
There was a problem hiding this comment.
Yeah, We have discussed it internally and decided to go live with only 10 commands for which I have added implementations and tests. We do not need Identity subcommands.
|
[Release] Update index.json for extension [ pscloud-1.0.0b1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=133670327&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.