Skip to content

Update request idle timeout range#9073

Merged
yanzhudd merged 1 commit intoAzure:mainfrom
Tratcher:patch-1
Aug 29, 2025
Merged

Update request idle timeout range#9073
yanzhudd merged 1 commit intoAzure:mainfrom
Tratcher:patch-1

Conversation

@Tratcher
Copy link
Copy Markdown
Contributor

@Tratcher Tratcher commented Aug 20, 2025

This is the range allowed by the underlying azure load balancer.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az containerapp env premium-ingress add/update

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings August 20, 2025 19:49
@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Aug 20, 2025

Hi @Tratcher,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Aug 20, 2025 •
edited
Loading

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Aug 20, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 20, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copilot AI reviewed Aug 20, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the documentation for the request_idle_timeout parameter to reflect the allowed range enforced by the underlying Azure Load Balancer. The change clarifies that the minimum value is 4 minutes (not 1) and adds a maximum value of 30 minutes.

  • Updated parameter help text to specify correct minimum and maximum values for request idle timeout

Comment thread src/containerapp/azext_containerapp/_params.py
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 20, 2025

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 20, 2025

Hi @Tratcher

Release Suggestions

Module: containerapp

  • Please log updates into to src/containerapp/HISTORY.rst
  • Update VERSION to 1.2.0b4 in src/containerapp/setup.py

Notes

@microsoft-github-policy-service microsoft-github-policy-service bot added the Auto-Assign Auto assign by bot label Aug 20, 2025
Greedygre
Greedygre reviewed Aug 21, 2025
View reviewed changes
Comment thread src/containerapp/azext_containerapp/_params.py
@Greedygre
Copy link
Copy Markdown
Contributor

Greedygre commented Aug 21, 2025

The CI failed due to Microsoft.Network update the api-version from 2024-05-01 to 2024-07-01.
I will raise a PR to update the related recording files.

vcr.errors.CannotOverwriteExistingCassetteException: Can't overwrite existing cassette ('/mnt/vss/_work/1/s/src/containerapp/azext_containerapp/tests/latest/recordings/test_containerappjob_create_with_environment_id.yaml') in your current record mode ('once').
E               No match for the request (<Request (PUT) [https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest.rg000001/providers/Microsoft.Network/virtualNetworks/name000005?api-version=2024-07-01>](https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest.rg000001/providers/Microsoft.Network/virtualNetworks/name000005?api-version=2024-07-01%3E)) was found.
E               Found 3 similar requests with 1 different matcher(s) :
E               
E               1 - (<Request (PUT) [https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest.rg000001/providers/Microsoft.Network/virtualNetworks/name000005?api-version=2024-05-01>).](https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest.rg000001/providers/Microsoft.Network/virtualNetworks/name000005?api-version=2024-05-01%3E).)
E               Matchers succeeded : ['method', 'scheme', 'host', 'port', 'path']
E               Matchers failed :
E               _custom_request_query_matcher - assertion failure :
E               None
E

@Greedygre
Copy link
Copy Markdown
Contributor

Greedygre commented Aug 22, 2025

The CI failed due to Microsoft.Network update the api-version from 2024-05-01 to 2024-07-01. I will raise a PR to update the related recording files.

vcr.errors.CannotOverwriteExistingCassetteException: Can't overwrite existing cassette ('/mnt/vss/_work/1/s/src/containerapp/azext_containerapp/tests/latest/recordings/test_containerappjob_create_with_environment_id.yaml') in your current record mode ('once').
E               No match for the request (<Request (PUT) [https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest.rg000001/providers/Microsoft.Network/virtualNetworks/name000005?api-version=2024-07-01>](https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest.rg000001/providers/Microsoft.Network/virtualNetworks/name000005?api-version=2024-07-01%3E)) was found.
E               Found 3 similar requests with 1 different matcher(s) :
E               
E               1 - (<Request (PUT) [https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest.rg000001/providers/Microsoft.Network/virtualNetworks/name000005?api-version=2024-05-01>).](https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/clitest.rg000001/providers/Microsoft.Network/virtualNetworks/name000005?api-version=2024-05-01%3E).)
E               Matchers succeeded : ['method', 'scheme', 'host', 'port', 'path']
E               Matchers failed :
E               _custom_request_query_matcher - assertion failure :
E               None
E

Hi @Tratcher
My PR has been merged, please sync the main branch.

@Tratcher
Copy link
Copy Markdown
Contributor Author

Tratcher commented Aug 22, 2025

@Greedygre rebased

@Greedygre
Copy link
Copy Markdown
Contributor

Greedygre commented Aug 22, 2025

Hi @yanzhudd
Can you help to take a look for this small pr that update the param description?
Thanks

@Tratcher
Copy link
Copy Markdown
Contributor Author

Tratcher commented Aug 28, 2025

@yanzhudd?

@yanzhudd yanzhudd merged commit 4a9e32b into Azure:main Aug 29, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@Greedygre Greedygre Greedygre approved these changes

@yanzhudd yanzhudd yanzhudd approved these changes

@howang-ms howang-ms Awaiting requested review from howang-ms howang-ms is a code owner

@Juliehzl Juliehzl Awaiting requested review from Juliehzl Juliehzl is a code owner

@yonzhan yonzhan Awaiting requested review from yonzhan

@wangzelin007 wangzelin007 Awaiting requested review from wangzelin007

@zhoxing-ms zhoxing-ms Awaiting requested review from zhoxing-ms

@jsntcy jsntcy Awaiting requested review from jsntcy

@ruslany ruslany Awaiting requested review from ruslany

@sanchitmehta sanchitmehta Awaiting requested review from sanchitmehta

@ebencarek ebencarek Awaiting requested review from ebencarek

@JennyLawrance JennyLawrance Awaiting requested review from JennyLawrance

@vinisoto vinisoto Awaiting requested review from vinisoto

@chinadragon0515 chinadragon0515 Awaiting requested review from chinadragon0515

@vturecek vturecek Awaiting requested review from vturecek

@torosent torosent Awaiting requested review from torosent

@pagariyaalok pagariyaalok Awaiting requested review from pagariyaalok

@jijohn14 jijohn14 Awaiting requested review from jijohn14

Assignees

@zhoxing-ms zhoxing-ms

Labels

Auto-Assign Auto assign by bot ContainerApp

Projects

None yet

Milestone

September 2025 (2025-09-02)

Development

Successfully merging this pull request may close these issues.

6 participants

@Tratcher @yonzhan @Greedygre @yanzhudd @zhoxing-ms