Skip to content

[AMG]: Update API spec to 2024-11-01 and remove SKU tier from create#9122

Closed
ABZhang0 wants to merge 4 commits intoAzure:mainfrom
ABZhang0:remove-sku-tier
Closed

[AMG]: Update API spec to 2024-11-01 and remove SKU tier from create#9122
ABZhang0 wants to merge 4 commits intoAzure:mainfrom
ABZhang0:remove-sku-tier

Conversation

@ABZhang0
Copy link
Copy Markdown
Contributor

@ABZhang0 ABZhang0 commented Sep 3, 2025

Related command

az grafana create, az grafana update

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

Copilot AI review requested due to automatic review settings September 3, 2025 00:50
@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Sep 3, 2025

❌Azure CLI Extensions Breaking Change Test
❌amg
rule cmd_name rule_message suggest_message
1007 - ParaRemove grafana create cmd grafana create removed parameter sku_tier please add back parameter sku_tier for cmd grafana create
1010 - ParaPropUpdate grafana create cmd grafana create update parameter service_account: updated property options from ['--api-key', '--service-account'] to ['--service-account'] please change property options from ['--service-account'] to ['--api-key', '--service-account'] for parameter service_account of cmd grafana create
1010 - ParaPropUpdate grafana update cmd grafana update update parameter service_account: updated property options from ['--api-key', '--service-account'] to ['--service-account'] please change property options from ['--service-account'] to ['--api-key', '--service-account'] for parameter service_account of cmd grafana update
⚠️ 1006 - ParaAdd grafana update cmd grafana update added parameter no_wait
⚠️ 1008 - ParaPropAdd grafana update cmd grafana update update parameter password: added property nargs=?
⚠️ 1010 - ParaPropUpdate grafana update cmd grafana update update parameter password: updated property aaz_type from string to AAZPasswordArg
⚠️ 1010 - ParaPropUpdate grafana update cmd grafana update update parameter password: updated property type from string to Password
⚠️ 1008 - ParaPropAdd grafana update cmd grafana update update parameter smtp_enabled: added property aaz_default=False

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @ABZhang0,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Sep 3, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@ABZhang0 ABZhang0 changed the title Update API spec to 2024-11-01 and remove SKU tier from create [AMG]: Update API spec to 2024-11-01 and remove SKU tier from create Sep 3, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 3, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Azure Managed Grafana (AMG) extension to use the latest API specification version 2024-11-01-preview and removes SKU tier configuration from the create command. The changes align with API updates and simplify the user experience by removing deprecated arguments.

  • Updated API version from 2023-09-01 to 2024-11-01-preview across all commands
  • Removed --sku-tier argument from az grafana create command
  • Replaced --api-key argument with --service-account for consistency

Reviewed Changes

Copilot reviewed 22 out of 32 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/amg/setup.py Version bump to 2.8.1
src/amg/azext_amg/azext_metadata.json Updated minimum CLI core version requirement
src/amg/azext_amg/tests/latest/test_amg_scenario.py Updated test commands to use --service-account instead of --api-key
src/amg/azext_amg/aaz/latest/grafana/_create.py Removed SKU tier argument and updated API version
src/amg/azext_amg/aaz/latest/grafana/_update.py Updated API version and argument handling
src/amg/azext_amg/aaz/latest/grafana/_*.py Updated API versions and added workspace name validation patterns
src/amg/HISTORY.rst Added changelog entry for version 2.8.1
Comments suppressed due to low confidence (5)

src/amg/azext_amg/aaz/latest/grafana/_create.py:1

  • The example comment still references the old SKU tier argument on line 19, but this argument has been removed from the command. The comment should be updated to reflect the current functionality.
# --------------------------------------------------------------------------------------------

src/amg/azext_amg/aaz/latest/grafana/_update.py:1

  • The help text was updated to remove the Go documentation reference, but the original line still exists. Only one help string should be present for the from_address argument.
# --------------------------------------------------------------------------------------------

src/amg/azext_amg/aaz/latest/grafana/_update.py:1

  • Similar to the previous comment, the help text for from_name has duplicate entries where the old version with Go documentation reference should be removed.
# --------------------------------------------------------------------------------------------

src/amg/azext_amg/aaz/latest/grafana/_update.py:1

  • The skip_verify help text also has duplicate entries where the old version with Go documentation reference should be removed.
# --------------------------------------------------------------------------------------------

src/amg/azext_amg/aaz/latest/grafana/_update.py:1

  • The start_tls_policy help text has duplicate entries where the old version with Go documentation reference should be removed.
# --------------------------------------------------------------------------------------------

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 3, 2025

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 3, 2025

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Sep 3, 2025
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Sep 3, 2025
Comment thread src/amg/azext_amg/aaz/latest/grafana/_update.py
@ABZhang0 ABZhang0 marked this pull request as draft September 4, 2025 03:22
@ABZhang0 ABZhang0 closed this Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot extension/grafana az grafana

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants