[AMG]: Update API spec to 2024-11-01 and remove SKU tier from create#9122
[AMG]: Update API spec to 2024-11-01 and remove SKU tier from create#9122ABZhang0 wants to merge 4 commits intoAzure:mainfrom
Conversation
❌Azure CLI Extensions Breaking Change Test
|
|
Hi @ABZhang0, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Azure Managed Grafana (AMG) extension to use the latest API specification version 2024-11-01-preview and removes SKU tier configuration from the create command. The changes align with API updates and simplify the user experience by removing deprecated arguments.
- Updated API version from 2023-09-01 to 2024-11-01-preview across all commands
- Removed
--sku-tierargument fromaz grafana createcommand - Replaced
--api-keyargument with--service-accountfor consistency
Reviewed Changes
Copilot reviewed 22 out of 32 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/amg/setup.py | Version bump to 2.8.1 |
| src/amg/azext_amg/azext_metadata.json | Updated minimum CLI core version requirement |
| src/amg/azext_amg/tests/latest/test_amg_scenario.py | Updated test commands to use --service-account instead of --api-key |
| src/amg/azext_amg/aaz/latest/grafana/_create.py | Removed SKU tier argument and updated API version |
| src/amg/azext_amg/aaz/latest/grafana/_update.py | Updated API version and argument handling |
| src/amg/azext_amg/aaz/latest/grafana/_*.py | Updated API versions and added workspace name validation patterns |
| src/amg/HISTORY.rst | Added changelog entry for version 2.8.1 |
Comments suppressed due to low confidence (5)
src/amg/azext_amg/aaz/latest/grafana/_create.py:1
- The example comment still references the old SKU tier argument on line 19, but this argument has been removed from the command. The comment should be updated to reflect the current functionality.
# --------------------------------------------------------------------------------------------
src/amg/azext_amg/aaz/latest/grafana/_update.py:1
- The help text was updated to remove the Go documentation reference, but the original line still exists. Only one help string should be present for the from_address argument.
# --------------------------------------------------------------------------------------------
src/amg/azext_amg/aaz/latest/grafana/_update.py:1
- Similar to the previous comment, the help text for from_name has duplicate entries where the old version with Go documentation reference should be removed.
# --------------------------------------------------------------------------------------------
src/amg/azext_amg/aaz/latest/grafana/_update.py:1
- The skip_verify help text also has duplicate entries where the old version with Go documentation reference should be removed.
# --------------------------------------------------------------------------------------------
src/amg/azext_amg/aaz/latest/grafana/_update.py:1
- The start_tls_policy help text has duplicate entries where the old version with Go documentation reference should be removed.
# --------------------------------------------------------------------------------------------
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
Related command
az grafana create,az grafana updateGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)