Unconditionally define custom-locations variables in enable_features()#9160
Unconditionally define custom-locations variables in enable_features()#9160justin-mccann wants to merge 1 commit intoAzure:mainfrom
Conversation
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Hi @justin-mccann, |
There was a problem hiding this comment.
Pull Request Overview
This PR addresses variable initialization issues in the enable_features() function by unconditionally defining final_enable_cl and custom_locations_oid variables before their potential use in conditional blocks.
- Initializes
final_enable_cltoFalseandcustom_locations_oidtoNonebefore theenable_clconditional block
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
Release SuggestionsModule: connectedk8s
Notes
|
|
The failing |
|
@yonzhan Any update here? |
|
This appears to be fixed in #9254 |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.