[Containerapp] az containerapp function: Add function key management commands#9163
[Containerapp] az containerapp function: Add function key management commands#9163khushishah513 wants to merge 2 commits intoAzure:mainfrom
az containerapp function: Add function key management commands#9163Conversation
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Hi @khushishah513, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
| * 'az containerapp function list-keys': List function keys for a specific function in a container app | ||
| * 'az containerapp function update-keys': Update specific function key for a specific function in a container app | ||
| * 'az containerapp function list-hostkeys': List host keys for a container app | ||
| * 'az containerapp function update-hostkeys': Update specific host key for a container app |
There was a problem hiding this comment.
please review these commands from Nitesh/Deep as well.
| * 'az containerapp function list-keys': List function keys for a specific function in a container app | ||
| * 'az containerapp function update-keys': Update specific function key for a specific function in a container app | ||
| * 'az containerapp function list-hostkeys': List host keys for a container app | ||
| * 'az containerapp function update-hostkeys': Update specific host key for a container app |
There was a problem hiding this comment.
we also have master key and system keys. Instead of adding separate commands for each type of keys, can we follow the same approach as that of az functionapp keys and az functionapp function keys
My suggestion is to have only one command that handles all kinds of function keys, following the az functionapp conventions.
az containerapp function keys list/delete/set --key-type {functionKeys, hostKey, masterKey, systemKeys} [--function-name] {} [--key-name] {} [--key-value] {}
- if keyType is
functionKeys, --function-name becomes mandatory parameter, else it is optional. - keyType is mandatory parameter
- list --> to view all keys with given keyType
- delete --> delete a key with given keyType and keyName (keyName required only when keyType is functionKeys. Is it possible to delete master key, host key in case of other Functions SKUs using
az functionapp keyscommand? - set --> add new key or update existing key. (Only update operation supported in host and master key. Add or update supported in functionKeys)
- function-name, key-name and key-value parameters will be applicable only in certain combination of commands.
There was a problem hiding this comment.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.