fix: add pydantic dependency for aks-agent#9165
Conversation
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Hi @nilo19, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds the pydantic-core dependency to the aks-agent extension and increments the version from 1.0.0b2 to 1.0.0b3. The changes also remove CODEOWNERS entries for the aks-agent extension.
- Add pydantic-core as a new dependency for the aks-agent extension
- Update version from 1.0.0b2 to 1.0.0b3
- Remove CODEOWNERS entry for the aks-agent extension
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/aks-agent/setup.py | Updates version and reorganizes dependencies, adding pydantic-core |
| src/aks-agent/.gitignore | Adds Poetry-related files to gitignore |
| .github/CODEOWNERS | Removes the aks-agent extension ownership entry |
| DEPENDENCIES = [ | ||
| "holmesgpt==0.12.6; python_version >= '3.10'", | ||
| "pytest-asyncio>=1.1.0", | ||
| "pydantic-core", |
There was a problem hiding this comment.
The pydantic-core dependency should include a version constraint for better dependency management and reproducible builds. Consider adding a minimum version or version range, e.g., 'pydantic-core>=2.0.0'.
| "pydantic-core", | |
| "pydantic-core>=2.0.0", |
There was a problem hiding this comment.
As suggested here, add a version constraint
microsoft-github-policy-service
bot
requested review from
FumingZhang,
yanzhudd,
yonzhan and
zhoxing-ms
|
nilo19
force-pushed
the
fix/aks-agent-dependency
branch
from
3ad0796 to
0c80da7
Compare
nilo19
force-pushed
the
fix/aks-agent-dependency
branch
from
0c80da7 to
43a52f1
Compare
|
|
||
| DEPENDENCIES = [ | ||
| "holmesgpt==0.12.6; python_version >= '3.10'", | ||
| "pytest-asyncio>=1.1.0", |
There was a problem hiding this comment.
why we install pytest-asyncio which seems to be for test?
|
@nilo19 there are conflicts need to be resolved |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.