[connectedk8s] Update extension CLI to v1.10.11#9303
Closed
bavneetsingh16 wants to merge 12 commits intoAzure:mainfrom
Closed
[connectedk8s] Update extension CLI to v1.10.11#9303bavneetsingh16 wants to merge 12 commits intoAzure:mainfrom
bavneetsingh16 wants to merge 12 commits intoAzure:mainfrom
Conversation
* forcedelete * format * add code owner * mypy
… '2025-08-01-preview' (#17)
…add E2E coverage and improve logging (#20) * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * Parameterize for airgapped clouds (#5) * Add parameterization for the airgapped clouds * Fix azdev style * MCR path function * azdev, ruff, and mypy --------- Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com> * Oras client fix to work with different MCRs (#6) Co-authored-by: mmcneal <mmcneal@microsoft.com> * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (#11) * update errors * format * style * update python version to 3.13 (#12) * Update cluster diagnostics image to 1.29.3 (#7) * Update cluster diagnostics helm chart to 1.29.3 * Fix lint issues --------- Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com> * RBAC deprecation & fix the issue * typo * fix comments * update tests * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (#11) * update errors * format * style * update python version to 3.13 (#12) * rebase * fix tests * fix version * fix mypy, lint * fix test * fix test * fix test * fix test * fix test * rename test * deprecate flags * rebase * rebase * bump version for release --------- Co-authored-by: Bavneet Singh <bavneetsingh@microsoft.com> Co-authored-by: Atchut Kumar Barli <atchut@gmail.com> Co-authored-by: mcnealm13 <57726243+mcnealm13@users.noreply.github.com> Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com> Co-authored-by: Bavneet Singh <33008256+bavneetsingh16@users.noreply.github.com> Co-authored-by: bgriddaluru <117554445+bgriddaluru@users.noreply.github.com> Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com> Co-authored-by: vithumma <vithumma@microsoft.com>
️✔️Azure CLI Extensions Breaking Change Test
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
Contributor
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
jsntcy,
yanzhudd,
yonzhan and
zhoxing-ms
microsoft-github-policy-service
bot
added
Connected Kubernetes
Auto-Assign
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the connectedk8s extension CLI to version 1.10.11, focusing on fixing MCR endpoint URL handling for Government cloud environments and removing hardcoded public ARM endpoint URLs.
- Refactored
get_mcr_pathfunction to accept active directory endpoint string parameter instead of CLICommand object - Updated all callers to pass the active directory endpoint explicitly
- Added special handling for US Government and China clouds to use public MCR
- Removed hardcoded ARM endpoint URLs from client factory
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/connectedk8s/setup.py | Updated version number from 1.10.10 to 1.10.11 |
| src/connectedk8s/azext_connectedk8s/_utils.py | Refactored get_mcr_path function signature and logic for cloud-specific MCR handling |
| src/connectedk8s/azext_connectedk8s/custom.py | Updated get_mcr_path call to pass active directory endpoint parameter |
| src/connectedk8s/azext_connectedk8s/_precheckutils.py | Updated get_mcr_path call to pass active directory endpoint parameter |
| src/connectedk8s/azext_connectedk8s/clientproxyhelper/_binaryutils.py | Updated get_mcr_path call to pass active directory endpoint parameter |
| src/connectedk8s/azext_connectedk8s/_client_factory.py | Removed hardcoded ARM endpoint URLs from client factory |
| src/connectedk8s/azext_connectedk8s/tests/unittests/test_utils_.py | Added comprehensive unit tests for the refactored get_mcr_path function |
| src/k8s-extension/azext_k8s_extension/utils.py | Applied same MCR path logic refactoring as in connectedk8s |
| src/k8s-extension/azext_k8s_extension/custom.py | Updated get_mcr_path call to pass active directory endpoint parameter |
| src/connectedk8s/HISTORY.rst | Added changelog entry for version 1.10.11 |
Contributor
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.