{AuthV2} az webapp auth update: Fix --excluded-paths logic#9311
Closed
a0x1ab wants to merge 4 commits intoAzure:mainfrom
Closed
{AuthV2} az webapp auth update: Fix --excluded-paths logic#9311a0x1ab wants to merge 4 commits intoAzure:mainfrom
az webapp auth update: Fix --excluded-paths logic#9311a0x1ab wants to merge 4 commits intoAzure:mainfrom
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
Contributor
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
3 tasks
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the --excluded-paths parsing logic in the az webapp auth update command to properly handle multiple input formats including JSON arrays and comma-separated values.
Key Changes:
- Updated excluded paths parsing to support both JSON array format and comma-separated strings
- Added comprehensive test coverage for various excluded paths input formats
- Bumped extension version to 1.0.1
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/authV2/setup.py | Incremented version from 1.0.0 to 1.0.1 |
| src/authV2/azext_authV2/custom.py | Replaced string slicing logic with JSON parsing that falls back to comma-separated parsing |
| src/authV2/azext_authV2/tests/latest/test_authV2_scenario.py | Added comprehensive test case covering single paths, comma-separated paths, JSON arrays, and special characters |
| src/authV2/HISTORY.rst | Added changelog entry for version 1.0.1 documenting the excluded paths parsing fix |
Contributor
|
4fd554e to
c8f7298
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az webapp auth update -g {resource-group} --excluded-paths {paths}Description
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.