[Containerapp] az containerapp sessionpool create: Add Shell container type#9361
[Containerapp] az containerapp sessionpool create: Add Shell container type#9361zhoxing-ms merged 13 commits intoAzure:mainfrom
az containerapp sessionpool create: Add Shell container type#9361Conversation
This reverts commit 7766ea8.
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| containerapp sessionpool create | cmd containerapp sessionpool create update parameter container_type: updated property choices from ['CustomContainer', 'NodeLTS', 'PythonLTS'] to ['CustomContainer', 'NodeLTS', 'PythonLTS', 'Shell'] |
|
Hi @ShichaoQiu, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
Hi @ShichaoQiu Release SuggestionsModule: containerapp
Notes
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for a new "Shell" container type to the containerapp sessionpool create command. This enhancement extends the existing functionality that previously supported only CustomContainer, PythonLTS, and NodeLTS container types.
- Added "Shell" as a new container type option for session pools
- Updated test coverage to include Shell container type validation
- Added help documentation with usage example
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/containerapp/azext_containerapp/_params.py | Added "Shell" to the enum of available container types for sessionpool create |
| src/containerapp/azext_containerapp/_help.py | Added example showing how to create a Shell container type session pool |
| src/containerapp/azext_containerapp/tests/latest/test_containerapp_sessionpool.py | Renamed test method to indicate e2e testing, added test for Shell container type creation, updated expected pool count assertions, and added cleanup for Shell pool |
| src/containerapp/HISTORY.rst | Added release note documenting the new Shell container type feature |
|
Please fix CI issues |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.