-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Application Gateway for Containers addon commands #9387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
1a5fbbd
d7f5571
88d3432
e242cd0
3e75d7c
ad4b754
0e8b3ba
c40c3af
7ee983e
e2a2c16
11aed85
5998eb8
78a9f91
055a3f7
47208c6
9520b8f
560f0f5
3a4d8ba
8f01427
b5d36b8
f4692ea
7f34b1c
4dba0d8
51e4e34
e967940
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -2663,6 +2663,12 @@ def aks_addon_list(cmd, client, resource_group_name, name): | |||||||||
| mc.ingress_profile.web_app_routing and | ||||||||||
| mc.ingress_profile.web_app_routing.enabled | ||||||||||
| ) | ||||||||||
| elif addon_name == "application-load-balancer": | ||||||||||
| enabled = bool( | ||||||||||
| mc.ingress_profile and | ||||||||||
| mc.ingress_profile.application_load_balancer and | ||||||||||
| mc.ingress_profile.application_load_balancer.enabled | ||||||||||
| ) | ||||||||||
| else: | ||||||||||
| if addon_name == "virtual-node": | ||||||||||
| addon_key += os_type | ||||||||||
|
|
@@ -2699,6 +2705,20 @@ def aks_addon_show(cmd, client, resource_group_name, name, addon): | |||||||||
| "config": mc.ingress_profile.web_app_routing, | ||||||||||
| } | ||||||||||
|
|
||||||||||
| # application-load-balancer is a special case, the configuration is stored in a separate profile | ||||||||||
| if addon == "application-load-balancer": | ||||||||||
| if ( | ||||||||||
| not mc.ingress_profile and | ||||||||||
| not mc.ingress_profile.application_load_balancer and | ||||||||||
|
Comment on lines
+2717
to
+2718
|
||||||||||
| not mc.ingress_profile and | |
| not mc.ingress_profile.application_load_balancer and | |
| not mc.ingress_profile or | |
| not mc.ingress_profile.application_load_balancer or |
Copilot
AI
Dec 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The aks_applicationloadbalancer_disable function should pass disable_application_load_balancer=True instead of enable_application_load_balancer=False. The decorator's update_application_load_balancer_profile method checks for both enable_application_load_balancer and disable_application_load_balancer parameters separately (lines 6654-6655 in managed_cluster_decorator.py). Setting enable_application_load_balancer=False would result in no operation being performed. This is also related to the missing disable_application_load_balancer parameter in the _aks_applicationloadbalancer_update function signature.
Uh oh!
There was an error while loading. Please reload this page.