{FrontDoor} Add Ddos ruleset support#9390
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @Ptnan7, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
Hi @Ptnan7
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates Azure Front Door WAF policy tests to standardize on Premium SKU and removes deprecated test scenarios. The changes align test cases with modern Azure Front Door capabilities by:
- Replacing
Standard_AzureFrontDoorandClassic_AzureFrontDoorSKUs withPremium_AzureFrontDooracross all test cases - Removing the
test_waf_policy_custom_rule_matchingtest method and associated test scenario - Removing
test_front_door_basic_scenarioand the entiretest_front_door_byoc_scenarios.pyfile - Updating the minimum CLI core version from 2.67.0 to 2.70.0
- Updating test recordings to reflect API version changes and Premium SKU usage
Reviewed Changes
Copilot reviewed 24 out of 30 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test_waf_scenarios.py | Changed SKU from Standard to Premium in test_waf_log_scrubbing; removed test_waf_policy_custom_rule_matching test method; updated SKU assertions throughout test_waf_policy_basic and test_waf_policy_custom_rules |
| test_front_door_scenarios.py | Removed test_front_door_basic_scenario test method |
| test_front_door_byoc_scenarios.py | Deleted entire file containing BYOC (Bring Your Own Certificate) test scenarios |
| test_waf_policy_managed_rules.yaml | Updated recordings with Premium SKU, newer API versions (2025-10-01), and updated timestamps |
| test_waf_policy_custom_rules.yaml | Updated recordings with Premium SKU and resolved API validation changes for groupBy field structure |
| test_waf_policy_custom_rule_matching.yaml | Deleted entire recording file for removed test |
| test_waf_policy_basic.yaml | Updated recordings with Premium SKU replacing both Classic and Standard SKUs throughout |
| test_waf_log_scrubbing.yaml | Updated recordings with API version changes to 2025-10-01 |
| test_waf_captcha.yaml | Updated recordings with API version changes to 2025-10-01 |
| azext_metadata.json | Bumped minimum CLI version from 2.67.0 to 2.70.0 |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
👆 |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
[Release] Update index.json for extension [ front-door-1.4.0 ] : https://dev.azure.com/msazure/One/_build/results?buildId=142670450&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.