Skip to content

{FrontDoor} Add Ddos ruleset support#9390

Merged
necusjz merged 3 commits intoAzure:mainfrom
Ptnan7:ddos-ruleset
Nov 5, 2025
Merged

{FrontDoor} Add Ddos ruleset support#9390
necusjz merged 3 commits intoAzure:mainfrom
Ptnan7:ddos-ruleset

Conversation

@Ptnan7
Copy link
Copy Markdown
Member

@Ptnan7 Ptnan7 commented Nov 4, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings November 4, 2025 23:11
@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Nov 4, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @Ptnan7,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Nov 4, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 4, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 4, 2025

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 4, 2025

Hi @Ptnan7

⚠️ Release Requirements

Module: front-door

  • ⚠️ Please update VERSION to be 1.3.1 in src/front-door/setup.py

Notes

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates Azure Front Door WAF policy tests to standardize on Premium SKU and removes deprecated test scenarios. The changes align test cases with modern Azure Front Door capabilities by:

  • Replacing Standard_AzureFrontDoor and Classic_AzureFrontDoor SKUs with Premium_AzureFrontDoor across all test cases
  • Removing the test_waf_policy_custom_rule_matching test method and associated test scenario
  • Removing test_front_door_basic_scenario and the entire test_front_door_byoc_scenarios.py file
  • Updating the minimum CLI core version from 2.67.0 to 2.70.0
  • Updating test recordings to reflect API version changes and Premium SKU usage

Reviewed Changes

Copilot reviewed 24 out of 30 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test_waf_scenarios.py Changed SKU from Standard to Premium in test_waf_log_scrubbing; removed test_waf_policy_custom_rule_matching test method; updated SKU assertions throughout test_waf_policy_basic and test_waf_policy_custom_rules
test_front_door_scenarios.py Removed test_front_door_basic_scenario test method
test_front_door_byoc_scenarios.py Deleted entire file containing BYOC (Bring Your Own Certificate) test scenarios
test_waf_policy_managed_rules.yaml Updated recordings with Premium SKU, newer API versions (2025-10-01), and updated timestamps
test_waf_policy_custom_rules.yaml Updated recordings with Premium SKU and resolved API validation changes for groupBy field structure
test_waf_policy_custom_rule_matching.yaml Deleted entire recording file for removed test
test_waf_policy_basic.yaml Updated recordings with Premium SKU replacing both Classic and Standard SKUs throughout
test_waf_log_scrubbing.yaml Updated recordings with API version changes to 2025-10-01
test_waf_captcha.yaml Updated recordings with API version changes to 2025-10-01
azext_metadata.json Bumped minimum CLI version from 2.67.0 to 2.70.0

@yonzhan yonzhan requested a review from necusjz November 4, 2025 23:31
@yonzhan yonzhan requested a review from kairu-ms November 4, 2025 23:31
@necusjz
Copy link
Copy Markdown
Member

necusjz commented Nov 4, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

@necusjz
Copy link
Copy Markdown
Member

necusjz commented Nov 5, 2025

Hi @Ptnan7

Release Suggestions

Module: front-door

  • Please log updates into to src/front-door/HISTORY.rst
  • Update VERSION to 1.3.1 in src/front-door/setup.py

Notes

👆

@necusjz
Copy link
Copy Markdown
Member

necusjz commented Nov 5, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 2 pipeline(s).

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Nov 5, 2025
@necusjz necusjz added skip-cal-version and removed release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. labels Nov 5, 2025
@necusjz necusjz merged commit fbdfa2f into Azure:main Nov 5, 2025
36 of 37 checks passed
@azclibot
Copy link
Copy Markdown
Collaborator

azclibot commented Nov 5, 2025

[Release] Update index.json for extension [ front-door-1.4.0 ] : https://dev.azure.com/msazure/One/_build/results?buildId=142670450&view=results

@Ptnan7 Ptnan7 deleted the ddos-ruleset branch November 5, 2025 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants