Skip to content

{AKS}: agent-init replaces model name with deployment name for Azure OpenAI service#9391

Merged
yanzhudd merged 5 commits intoAzure:mainfrom
mainred:update-init-for-aopenai
Nov 6, 2025
Merged

{AKS}: agent-init replaces model name with deployment name for Azure OpenAI service#9391
yanzhudd merged 5 commits intoAzure:mainfrom
mainred:update-init-for-aopenai

Conversation

@mainred
Copy link
Copy Markdown
Member

@mainred mainred commented Nov 5, 2025


  • replace model name with deployment name for Azure OpenAI service
  • remove importing holmesgpt to resolve the latency issue
  • support azure openai MODEL_NAME for backward compatibility

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings November 5, 2025 00:14
@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Nov 5, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Nov 5, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 5, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Azure OpenAI provider configuration to use DEPLOYMENT_NAME instead of MODEL_NAME for better clarity when configuring Azure OpenAI deployments. The version is bumped to 1.0.0b9.

  • Renamed parameter from MODEL_NAME to DEPLOYMENT_NAME in Azure provider schema
  • Updated the hint text to be more descriptive
  • Updated version and changelog

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/aks-agent/setup.py Bumped version from 1.0.0b8 to 1.0.0b9
src/aks-agent/azext_aks_agent/agent/llm_providers/azure_provider.py Renamed MODEL_NAME to DEPLOYMENT_NAME in parameter schema and updated hint text
src/aks-agent/HISTORY.rst Added changelog entry for version 1.0.0b9 describing the parameter name change
Comments suppressed due to low confidence (2)

src/aks-agent/azext_aks_agent/agent/llm_providers/azure_provider.py:65

  • The parameter name was changed from MODEL_NAME to DEPLOYMENT_NAME in the schema (line 35), but this line still references MODEL_NAME. This will cause the validation to fail because the parameter won't be found. Update this to params.get(\"DEPLOYMENT_NAME\").
        model_name = params.get("MODEL_NAME")

src/aks-agent/azext_aks_agent/agent/llm_providers/azure_provider.py:71

  • [nitpick] After fixing the parameter retrieval on line 65, consider renaming the local variable from model_name to deployment_name throughout this method (lines 65, 71, 77) to better reflect that it represents the Azure deployment name, not the model name. This aligns with the schema change and improves code clarity.
        url = urljoin(api_base, f"openai/deployments/{model_name}/chat/completions")

@mainred mainred force-pushed the update-init-for-aopenai branch from 96a534a to f1e9705 Compare November 5, 2025 01:11
@mainred mainred force-pushed the update-init-for-aopenai branch from f1e9705 to 38fa9a7 Compare November 5, 2025 01:13
@yanzhudd yanzhudd merged commit 4ba36d5 into Azure:main Nov 6, 2025
25 checks passed
@azclibot
Copy link
Copy Markdown
Collaborator

azclibot commented Nov 6, 2025

[Release] Update index.json for extension [ aks-agent-1.0.0b9 ] : https://dev.azure.com/msazure/One/_build/results?buildId=142828754&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants