Updating the Client side proxy version by gabemousa · Pull Request #9393 · Azure/azure-cli-extensions

gabemousa · 2025-11-05T18:49:30Z

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
My extension version conforms to the Extension version schema

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

* forcedelete * format * add code owner * mypy

… '2025-08-01-preview' (#17)

…add E2E coverage and improve logging (#20) * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * Parameterize for airgapped clouds (#5) * Add parameterization for the airgapped clouds * Fix azdev style * MCR path function * azdev, ruff, and mypy --------- Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com> * Oras client fix to work with different MCRs (#6) Co-authored-by: mmcneal <mmcneal@microsoft.com> * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (#11) * update errors * format * style * update python version to 3.13 (#12) * Update cluster diagnostics image to 1.29.3 (#7) * Update cluster diagnostics helm chart to 1.29.3 * Fix lint issues --------- Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com> * RBAC deprecation & fix the issue * typo * fix comments * update tests * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (#11) * update errors * format * style * update python version to 3.13 (#12) * rebase * fix tests * fix version * fix mypy, lint * fix test * fix test * fix test * fix test * fix test * rename test * deprecate flags * rebase * rebase * bump version for release --------- Co-authored-by: Bavneet Singh <bavneetsingh@microsoft.com> Co-authored-by: Atchut Kumar Barli <atchut@gmail.com> Co-authored-by: mcnealm13 <57726243+mcnealm13@users.noreply.github.com> Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com> Co-authored-by: Bavneet Singh <33008256+bavneetsingh16@users.noreply.github.com> Co-authored-by: bgriddaluru <117554445+bgriddaluru@users.noreply.github.com> Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com> Co-authored-by: vithumma <vithumma@microsoft.com>

* add agc overrides * update gns endpoint * add indentation * fix linter error * fix ruff formatting * move overrides to it's own method * update method * update ruff formatting

* add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * Parameterize for airgapped clouds (#5) * Add parameterization for the airgapped clouds * Fix azdev style * MCR path function * azdev, ruff, and mypy --------- Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com> * Oras client fix to work with different MCRs (#6) Co-authored-by: mmcneal <mmcneal@microsoft.com> * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (#11) * update errors * format * style * update python version to 3.13 (#12) * Update cluster diagnostics image to 1.29.3 (#7) * Update cluster diagnostics helm chart to 1.29.3 * Fix lint issues --------- Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com> * RBAC deprecation & fix the issue * typo * fix comments * update tests * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (#11) * update errors * format * style * update python version to 3.13 (#12) * rebase * fix tests * fix version * fix mypy, lint * fix test * fix test * fix test * fix test * fix test * rename test * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * fix CI testcases for nodepool image issues (#8) * update python version to 3.13 (#12) * changes to support gateway association/disassociation for api version '2025-08-01-preview' (#17) * [Azure RBAC] Deprecate 3P mode flags, fix Azure RBAC enablement bug, add E2E coverage and improve logging (#20) * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * Parameterize for airgapped clouds (#5) * Add parameterization for the airgapped clouds * Fix azdev style * MCR path function * azdev, ruff, and mypy --------- Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com> * Oras client fix to work with different MCRs (#6) Co-authored-by: mmcneal <mmcneal@microsoft.com> * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (#11) * update errors * format * style * update python version to 3.13 (#12) * Update cluster diagnostics image to 1.29.3 (#7) * Update cluster diagnostics helm chart to 1.29.3 * Fix lint issues --------- Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com> * RBAC deprecation & fix the issue * typo * fix comments * update tests * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (#11) * update errors * format * style * update python version to 3.13 (#12) * rebase * fix tests * fix version * fix mypy, lint * fix test * fix test * fix test * fix test * fix test * rename test * deprecate flags * rebase * rebase * bump version for release --------- Co-authored-by: Bavneet Singh <bavneetsingh@microsoft.com> Co-authored-by: Atchut Kumar Barli <atchut@gmail.com> Co-authored-by: mcnealm13 <57726243+mcnealm13@users.noreply.github.com> Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com> Co-authored-by: Bavneet Singh <33008256+bavneetsingh16@users.noreply.github.com> Co-authored-by: bgriddaluru <117554445+bgriddaluru@users.noreply.github.com> Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com> Co-authored-by: vithumma <vithumma@microsoft.com> * remove breaking change announcement for removed flags --------- Co-authored-by: Bavneet Singh <bavneetsingh@microsoft.com> Co-authored-by: Atchut Kumar Barli <atchut@gmail.com> Co-authored-by: mcnealm13 <57726243+mcnealm13@users.noreply.github.com> Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com> Co-authored-by: Bavneet Singh <33008256+bavneetsingh16@users.noreply.github.com> Co-authored-by: bgriddaluru <117554445+bgriddaluru@users.noreply.github.com> Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com> Co-authored-by: vithumma <vithumma@microsoft.com>

azure-client-tools-bot-prd · 2025-11-05T18:49:33Z

Validation for Breaking Change Starting...

Thanks for your contribution!

azure-client-tools-bot-prd · 2025-11-05T18:49:36Z

Hi @gabemousa,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

github-actions · 2025-11-05T18:49:53Z

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

yonzhan · 2025-11-05T18:49:55Z

Thank you for your contribution! We will review the pull request and get back to you soon.

github-actions · 2025-11-05T18:53:43Z

Hi @gabemousa

⚠️ Release Requirements

Module: connectedk8s

⚠️ Please update VERSION to be 2.0.0 in src/connectedk8s/setup.py

Module: k8s-extension

Please log updates into to src/k8s-extension/HISTORY.rst
Update VERSION to 1.7.1 in src/k8s-extension/setup.py

Notes

For more info about extension versioning, please refer to Extension version schema

Copilot

Pull Request Overview

This PR adds a comprehensive testing framework for the connectedk8s Azure CLI extension, including test suites for various scenarios (WorkloadIdentity, Gateway, Proxy, etc.), along with supporting infrastructure and a version bump for the CLIENT_PROXY_VERSION constant.

Key Changes:

Added test infrastructure with Pester-based PowerShell test suites for multiple scenarios
Added helper scripts for bootstrapping, testing, and configuration
Updated CLIENT_PROXY_VERSION from "1.3.029301" to "1.3.032281"

Reviewed Changes

Copilot reviewed 19 out of 23 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
testing/test/helper/Constants.ps1	Defines test configuration constants
testing/test/configurations/*.Tests.ps1	Test suites for various scenarios (WorkloadIdentity, Troubleshoot, Proxy, Gateway, ForcedDelete, EnableDisableFeatures, ConnectProxy, BasicOnboarding, AutoUpdate)
testing/Test.ps1	Main test execution script
testing/Bootstrap.ps1	Environment setup script
testing/settings.template.json	Configuration template
testing/pipeline/*.yml	CI/CD pipeline definitions
src/connectedk8s/azext_connectedk8s/_constants.py	Version constant update

Copilot · 2025-11-05T19:00:03Z

+                if ($isProxyEnabled -match "isProxyEnabled: false") {
+                    break
+                }
+                break


Duplicate break statement at line 49 causes unreachable code. The second break statement will execute unconditionally when $provisioningState equals $SUCCEEDED, regardless of the proxy status check result. This means the test will pass even if the proxy wasn't actually disabled. Remove the redundant break at line 49.

Suggested change

break

Copilot · 2025-11-05T19:00:03Z

+    BeforeAll {
+        . $PSScriptRoot/../helper/Constants.ps1
+
+        $SelfHostedIssuer = "https://eastus.oic.prod-aks.azure.com/fc50e82b-3761-4218-8691-d98bcgb146da/e6c4bf03-84d9-480c-a269-37a41c28c5cb/"


Typo in the URL path segment 'd98bcgb146da' appears to contain 'bcgb' which should likely be 'bcfb' based on typical GUID patterns.

Suggested change

$SelfHostedIssuer = "https://eastus.oic.prod-aks.azure.com/fc50e82b-3761-4218-8691-d98bcgb146da/e6c4bf03-84d9-480c-a269-37a41c28c5cb/"

$SelfHostedIssuer = "https://eastus.oic.prod-aks.azure.com/fc50e82b-3761-4218-8691-d98bcfb146da/e6c4bf03-84d9-480c-a269-37a41c28c5cb/"

…ctedk8s into gabrielmousa/proxyupdate

github-actions · 2025-11-05T19:56:36Z

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Bavneet Singh and others added 14 commits September 30, 2025 09:40

add pester tests for connectedk8s cli extension

20aecd7

Pass the force delete param to the API call (#4)

40926a3

* forcedelete * format * add code owner * mypy

fix CI testcases for nodepool image issues (#8)

8f068a8

update python version to 3.13 (#12)

ad1ce1d

changes to support gateway association/disassociation for api version…

2121694

… '2025-08-01-preview' (#17)

Merge branch 'Azure:main' into main

ed5b5e2

remove hardcoded public ARM endpoint url for fairfax and mooncake (#24)

9038227

Bug Fix for FFX mcr url (#22)

002220d

[connectedk8s] update release notes and version (#26)

6c0a24b

Add Helm Overrides for AGC (#23)

3ca7ae1

* add agc overrides * update gns endpoint * add indentation * fix linter error * fix ruff formatting * move overrides to it's own method * update method * update ruff formatting

update prediag version (#27)

979a4c3

Updating the proxy version constant

2a3d246

Copilot AI review requested due to automatic review settings November 5, 2025 18:49

azure-client-tools-bot-prd bot added this to the November 2025 (2025-11-18) milestone Nov 5, 2025

Copilot AI reviewed Nov 5, 2025

View reviewed changes

Merge branch 'main' of https://github.com/AzureArcForKubernetes/conne…

ef09b9b

…ctedk8s into gabrielmousa/proxyupdate

github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Nov 5, 2025

gabemousa closed this Nov 5, 2025

gabemousa deleted the gabrielmousa/proxyupdate branch November 5, 2025 23:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updating the Client side proxy version#9393

Updating the Client side proxy version#9393
gabemousa wants to merge 15 commits intoAzure:mainfrom
AzureArcForKubernetes:gabrielmousa/proxyupdate

gabemousa commented Nov 5, 2025

Uh oh!

azure-client-tools-bot-prd bot commented Nov 5, 2025

Uh oh!

azure-client-tools-bot-prd bot commented Nov 5, 2025

Uh oh!

github-actions bot commented Nov 5, 2025

Uh oh!

yonzhan commented Nov 5, 2025

Uh oh!

github-actions bot commented Nov 5, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 5, 2025

Uh oh!

Copilot AI Nov 5, 2025

Uh oh!

github-actions bot commented Nov 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

	$SelfHostedIssuer = "https://eastus.oic.prod-aks.azure.com/fc50e82b-3761-4218-8691-d98bcgb146da/e6c4bf03-84d9-480c-a269-37a41c28c5cb/"
	$SelfHostedIssuer = "https://eastus.oic.prod-aks.azure.com/fc50e82b-3761-4218-8691-d98bcfb146da/e6c4bf03-84d9-480c-a269-37a41c28c5cb/"

Conversation

gabemousa commented Nov 5, 2025

Related command

General Guidelines

About Extension Publish

Uh oh!

azure-client-tools-bot-prd bot commented Nov 5, 2025

Uh oh!

azure-client-tools-bot-prd bot commented Nov 5, 2025

Uh oh!

github-actions bot commented Nov 5, 2025

Uh oh!

yonzhan commented Nov 5, 2025

Uh oh!

github-actions bot commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Release Requirements

Module: connectedk8s

Module: k8s-extension

Notes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes:

Reviewed Changes

Uh oh!

Copilot AI Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 5, 2025

CodeGen Tools Feedback Collection

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

github-actions bot commented Nov 5, 2025 •

edited

Loading